feat(neovim): migrate typescript lsps to tsc - #6555
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to migrate the Neovim TypeScript language server setup away from tsserver/vtsls/tsgo and toward a tsc-based configuration, including updating the build tooling and removing the nvim-vtsls submodule.
Changes:
- Updates Mason-installed tooling list to drop
vtsls/typescript-language-server/tsgoand addtsc. - Reworks Neovim TypeScript LSP enablement and organize-imports hook to target an LSP client named
tsc. - Removes the
nvim-vtslsgit submodule entry.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mk/build.mk | Adjusts Mason package install targets for TypeScript-related tooling. |
| home/.config/nvim/plugin/typescript.lua | Switches TypeScript LSP attach/enable logic to a tsc-named server. |
| .gitmodules | Drops the nvim-vtsls submodule entry. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
27
to
32
| vim.api.nvim_create_autocmd('FileType', { | ||
| once = true, | ||
| pattern = vim.lsp.config[typescript_lsp].filetypes, | ||
| pattern = vim.lsp.config['tsc'].filetypes, | ||
| callback = function() | ||
| if typescript_lsp == 'vtsls' then | ||
| vim.cmd.packadd('nvim-vtsls') | ||
| end | ||
| vim.lsp.enable(typescript_lsp) | ||
| vim.lsp.enable('tsc') | ||
| end, |
Comment on lines
208
to
+218
| @@ -215,9 +215,7 @@ $(eval $(call mason_package,json-lsp)) | |||
| $(eval $(call mason_package,html-lsp)) | |||
| $(eval $(call mason_package,css-lsp)) | |||
| $(eval $(call mason_package,js-debug-adapter)) | |||
| $(eval $(call mason_package,vtsls)) # TODO: remove once tsgo is stable | |||
| $(eval $(call mason_package,typescript-language-server)) # TODO: remove once tsgo is stable | |||
| $(eval $(call mason_package,tsgo)) | |||
| $(eval $(call mason_package,tsc)) | |||
ignore binaries that do not support --lsp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.