-
Notifications
You must be signed in to change notification settings - Fork 33
Enhance Monitoring PDPs documentation #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for permitio-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the Monitoring PDPs documentation by providing comprehensive guidance on the PDP Monitoring page, its purpose, and how to interpret connection statuses. The documentation has been restructured to clarify operational expectations and address common misconceptions about PDP status indicators.
Changes:
- Updated sidebar configuration to use explicit doc type with a custom label
- Completely rewrote the monitoring PDPs documentation to provide detailed operational guidance
- Added sections explaining connection status interpretation, common scenarios for red PDPs, and version management
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sidebars.js | Changed sidebar entry from simple string reference to explicit doc type configuration with custom label |
| docs/how-to/monitoring-pdps/monitoring-pdps.mdx | Comprehensive rewrite of monitoring documentation including EAP notice, connection status guidance, timeout configuration, and version management best practices |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|  | ||
| # Monitoring PDPs | ||
| :::note Early Access Program | ||
| The PDP Monitoring page is an **Early Access Program (EAP)** feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Omer told me to add EAP here
zeevmoney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alon-boshi th
| The Monitoring Page retrieves data via the [PDP Statistics API](./../../api/pdp-statistics.mdx), ensuring up-to-date insights. | ||
|
|
||
|  | ||
| # Monitoring PDPs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add frontmatter at the beginning of the file:
---
sidebar_position: 1
title: Monitoring PDPs
---
# Monitoring PDPsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do
| - [PDP Statistics API](../../api/pdp-statistics) — Programmatic access to PDP monitoring data | ||
| - [PDP Webhooks](../../api/pdp-webhooks) — Real-time notifications for PDP events | ||
| - [PDP Overview](../../concepts/pdp/overview) — Learn more about Policy Decision Points | ||
| - [PDP Configuration](../../concepts/pdp/configuration) — Configure PDP settings and timeouts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use absolute paths from the docs root for more resilience:
/concepts/pdp/overviewinstead of../../concepts/pdp/overview/concepts/pdp/configurationinstead of../../concepts/pdp/configuration/api/pdp-statisticsinstead of../../api/pdp-statistics/api/pdp-webhooksinstead of../../api/pdp-webhooks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do
|
@alon-boshi I don't see the page in the preview, what is the path for it? |
| "how-to/monitoring-pdps/monitoring-pdps", | ||
| { | ||
| type: "doc", | ||
| id: "how-to/monitoring-pdps/monitoring-pdps", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| id: "how-to/monitoring-pdps/monitoring-pdps", | |
| id: "how-to/monitoring-pdps", |
No description provided.