fix: httpsig key order - #1114
Open
speeddragon wants to merge 2 commits into
Open
Conversation
speeddragon
marked this pull request as ready for review
September 4, 2026 19:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the original committed-key order when converting messages to and from httpsig@1.0.
HTTPSig previously derived its encoded component list from
maps:keys/1, which does not retain theorder of the source commitment. This could invalidate commitments originating from another codec,
particularly signed L1 transactions where field and tag order is significant.
Changes
content-digest,ao-body-key, escaped keys, and+linkkeys.tx@1.0→structured@1.0→httpsig@1.0→structured@1.0.Example
5Srj7HjQN4NNzK9BLxAOUNDCodmXhQzb6lWLIFD7D5Efails to verify becausecommittedfield order is different from when the message was signed.(without order)
vs
(with order)