feat(process): bound cached now freshness - #1083
Draft
samcamwilliams wants to merge 1 commit into
Draft
samcamwilliams wants to merge 1 commit into
samcamwilliams wants to merge 1 commit into
Conversation
Cached /now reads can otherwise hide newly scheduled assignments indefinitely. Record the scheduler target before computation and refresh its timestamp only when that slot is durably cached. Requests with a finite max-age then return through the scheduler and compute path when the cached state is stale; the call-site default remains infinity, so no redundant hb_opts default is required. Apply the optional process-store and existing process-cache scope consistently to process cache reads and writes. Keep these single-consumer helpers private to dev_process_cache, store freshness as a normal cache message and stable link, and preserve normal hb_ao resolution semantics. Repair the process-cache backend suite so it actually exercises FS, LMDB, and volatile stores. Retain real process fixtures and strict message matching, and add AO-level expiration plus isolated process-store coverage. Validation: - rebar3 as test compile - rebar3 device test -d dev_process,dev_process_cache --timeout 180 (14 passed) - rebar3 eunit-all (changed tests pass; 3519 passed, with 5 unrelated edge failures: one push peer-routing failure reproduced on detached clean edge and four existing legacy scheduler HTTP failures)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add computed-at time tracking to the
process-cache. This allows nodes to set the maximum frequency a process will be refreshed at, and requests to suggest the maximum age of a computed result that they would like to receive. I think this PR needs to be rewritten so submitting as a draft. The idea is sensible and necessary, though.