feat(React19): Add support for React19#40
Merged
rebeccaalpert merged 4 commits intopatternfly:mainfrom Jun 17, 2025
Merged
Conversation
2 tasks
cb79798 to
2a6071c
Compare
thatblindgeye
approved these changes
Jun 6, 2025
kmcfaul
approved these changes
Jun 17, 2025
Contributor
kmcfaul
left a comment
There was a problem hiding this comment.
I'm fine with leaving the v17 warnings until its requested, since this extension is deprecated and this would have been an old bug.
|
🎉 This PR is included in version 6.1.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgraded dependencies for test runner because it was no longer working - version 2 is deprecated
Added React19 support
Removed generated files from git and added to .gitignore
Checked with 19 and it builds but gets docs error as expected
18 builds and works
17 builds but there are some React errors
I checked against main branch and it has similar errors there. useId was introduced in React 18, so that's probably been broken for a while. Unsure if we want to open a follow-up issue or shrug since no one has complained about React 17 support being broken.