Skip to content

Page cdc correction #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Handy-caT merged 2 commits into from
Jun 28, 2025
Merged

Page cdc correction #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8742938
update indexset version
Handy-caT Jun 28, 2025
d4b45dc
version bump
Handy-caT Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ members = ["codegen", "tools/create-data-file", "tools/dump-data-file"]

[package]
name = "data_bucket"
version = "0.2.6"
version = "0.2.7"
edition = "2021"
authors = ["Handy-caT"]
license = "MIT"
Expand All @@ -19,7 +19,7 @@ rkyv = { version = "0.8.9", features = ["uuid-1"] }
lockfree = "0.5.1"
uuid = { version = "1.11.0", features = ["v4"] }
ordered-float = "5.0.0"
indexset = { version = "0.12.2", features = ["concurrent", "cdc", "multimap"] }
# indexset = { path = "../indexset", version = "0.12.0", features = ["concurrent", "cdc", "multimap"] }
indexset = { version = "0.12.3", features = ["concurrent", "cdc", "multimap"] }
# indexset = { path = "../indexset", version = "0.12.2", features = ["concurrent", "cdc", "multimap"] }
# indexset = { git = "https://github.com/Handy-caT/indexset", branch = "multimap-range-fix", version = "0.12.0", features = ["concurrent", "cdc", "multimap"] }
tokio = { version = "1", features = ["full"] }
2 changes: 1 addition & 1 deletion src/page/index/page_cdc_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ where
}

fn apply_remove_at(&mut self, index: usize) -> eyre::Result<()> {
// For remove we first remove slot entry for index value
// For remove we first remove slot entry for index value
let value_position = self.slots.remove(index);
// We push 0 in the tail because slots size should be fixed.
self.slots.push(0);
Expand Down
5 changes: 4 additions & 1 deletion src/page/index/page_for_unsized_cdc_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ where
value,
index,
} => {
if value == max_value {
// we are checking if index is non-zero because for non-unique indexes this is possible and will
// lead to panic, but in this case new node_id will be same to current node_id so it's change
// will not affect at all.
if value == max_value && index != 0 {
let new_node_id = self
.index_values
.get(index - 1)
Expand Down
Loading