Macos support into main #228
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,7 @@ Usage: local-build-macos.command --output-dir DIR [options] | |
| --retro-rewind-package-dir DIR RetroRewind6 directory (required for Retro Rewind) | ||
| --retro-wfc-offline-dir DIR Directory containing binary/payload.RMCPD00.bin | ||
| --skip-retro-wfc-payload Build Retro Rewind without the shared Retro-WFC payload | ||
| --force-clean-build Delete local generated and current-architecture native build caches | ||
| --parallel N Pin translation and build parallelism | ||
| --cmake PATH --ninja PATH Override build tools | ||
| --dotnet PATH Override dotnet | ||
|
|
@@ -56,7 +56,9 @@ while (($#)); do | |
| done | ||
|
|
||
| [[ $(uname -s) == Darwin ]] || fail 'this build script is for macOS only' | ||
| macos_arch=$(uname -m) | ||
| case "$macos_arch" in arm64|x86_64) ;; *) fail "unsupported macOS architecture: $macos_arch" ;; esac | ||
| macos_deployment_target=12.0 | ||
| workspace=$(cd "$workspace" && pwd) | ||
| [[ -n "$output_dir" ]] || fail '--output-dir is required' | ||
| case "$profile" in base|retro-rewind|both) ;; *) fail '--profile must be base, retro-rewind, or both' ;; esac | ||
|
|
@@ -73,7 +75,8 @@ for tool in "$cmake_bin" "$ninja_bin" clang clang++ shasum; do command -v "$tool | |
|
|
||
| project="$workspace/projects/mkwii/recomp.yml"; assets="$workspace/Assets"; generated="$workspace/generated" | ||
| functions="$generated/functions"; metadata="$generated/base_translation_output.json"; manifest_dir="$workspace/build/base" | ||
| manifest="$manifest_dir/mkwii_base_manifest.json"; shards="$generated/build_shards" | ||
| native_build="$workspace/native-build-macos-$macos_arch" | ||
| assert_file "$project" 'translation project' | ||
| if [[ -n "$game" ]]; then "$script_dir/macos/extract-disc.command" --game "$game" --assets-dir "$assets" --nodtool "$nodtool"; fi | ||
| assert_file "$assets/main.dol" 'extracted main.dol'; assert_file "$assets/StaticR.rel" 'extracted StaticR.rel' | ||
|
|
@@ -131,9 +134,11 @@ if (( builds_retro )); then args+=(--resolved-profile "$mod_out/resolved_dispatc | |
| step emit-build-shards 'Preparing native build shards'; translator "${args[@]}" | ||
|
|
||
| step configure-native 'Configuring the native toolchain' | ||
| # Use Aurora's pinned SDL3 source on macOS. A system SDL3 can be older than | ||
| # Aurora's required API even when find_package() succeeds. | ||
| "$cmake_bin" -S "$workspace/runtime" -B "$native_build" -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_MAKE_PROGRAM="$ninja_bin" -DCMAKE_OSX_ARCHITECTURES="$macos_arch" -DCMAKE_OSX_DEPLOYMENT_TARGET="$macos_deployment_target" -DMKW_TRANSLATED_COMPILE_JOBS="$translated_jobs" -DAURORA_SDL3_PROVIDER=vendor | ||
| targets=(); [[ "$profile" != retro-rewind ]] && targets+=(WiiCompiled); [[ "$profile" != base ]] && targets+=(RetroRewind) | ||
| step compile "Compiling ${targets[*]} locally"; "$cmake_bin" --build "$native_build" --target "${targets[@]}" --parallel "$global_jobs" | ||
| if [[ "$profile" != retro-rewind ]]; then "$script_dir/macos/publish-app.command" --build-dir "$native_build" --product WiiCompiled --output-dir "${base_output_dir:-$output_dir}" --architecture "$macos_arch" --minimum-system-version "$macos_deployment_target"; fi | ||
| if (( builds_retro )); then "$script_dir/macos/publish-app.command" --build-dir "$native_build" --product RetroRewind --output-dir "$output_dir" --architecture "$macos_arch" --minimum-system-version "$macos_deployment_target"; fi | ||
| printf 'MKWCBUILD:OUTPUT=%s\n' "$output_dir" | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | 🏗️ Heavy lift
🔎 Supported by static analysis
🏁 Script executed:
Repository: patchzyy/Wiicompiled
Length of output: 18280
🏁 Script executed:
Repository: patchzyy/Wiicompiled
Length of output: 50376
🌐 Web query:
Apple macOS pkgutil --check-signature unsigned package exit status man page💡 Result:
<search_synthesis>
When using the pkgutil --check-signature command on macOS, the exit status of the command does not depend solely on whether the package is signed or unsigned; rather, it primarily reflects whether the command executed successfully [1]. According to technical community documentation and practical testing, the pkgutil --check-signature command generally exits with a status of 0 when it successfully completes the verification process, regardless of whether that verification result indicates the package is signed or unsigned [1]. An unsigned package will return a status message stating Status: no signature in the terminal output, but the command itself will still typically exit with 0 [2][3][1]. The man page for pkgutil does not explicitly document specific exit codes for different signature states [4][5][6][7]. Because the tool is designed to report the validity and trust of a signature (or the lack thereof) to standard output, you should rely on parsing the textual output of the command (e.g., searching for "no signature") in automated workflows rather than relying on the exit status [2][1].
</search_synthesis>
<source_evidence>
Citations:
Sign and notarize the release package.
build-setup-pkg.commandpasses no--installer-identity, so it copies the unsigned package.pkgutil --check-signaturereports this state but does not reject it. The release job then uploads the same unsigned artifact. No later signing, notarization, or stapling step exists.Make the Developer ID Installer certificate and private key available through repository secrets. Pass its identity name with
--installer-identity. Notarize and staple the final package before upload. The builder has no environment-based signing fallback.🤖 Prompt for AI Agents