DLNA library upgrades#70
Conversation
|
can I force push to your branch here - or would resolving the merge make it difficult for you? |
| if(mediaRouteItem != null) { | ||
| MediaRouteButton mediaRouteButton = (MediaRouteButton) MenuItemCompat.getActionView(mediaRouteItem); | ||
| mediaRouteButton.setDialogFactory(new CustomMediaRouteDialogFactory()); | ||
| //mediaRouteButton.setDialogFactory(new CustomMediaRouteDialogFactory()); |
There was a problem hiding this comment.
is commenting this out intentional?
There was a problem hiding this comment.
I commented it out since it had no visual effect on the theme which I think was the whole reason behind the class. But it did however prevent proper handling of touch events outside the dialog from closing it. I can put it back if you want but the stock API seems to follow the theme anyways, maybe something that was added.
There was a problem hiding this comment.
ah.. I see. If none of this is needed, we can probably remove all of the related code, no?
There was a problem hiding this comment.
Yup I think so, unless additional implementation was planned, at this point Proguard is probably minimizing it out.
I believe that would work fine for me, I have your remote and mine in my local repository so we could work on a like named branch across both forks and I could merge there. There are many ways to do it so however you feel is best works for me. |
|
I just added you as a collaborator so you can just add my remote and commit to the API-36 branch and they will show up here. That should prevent a potential history loss as with a force push. I could just hold off on any commits until you force push if you're more comfortable with that. |
|
I restructured your commits and merged the ones that do not require bumping minSdk. I would probably do another patch release before bumping minSdk with 5.7.0. Going to test the committed version for a few days now. |
|
Sounds good, I'll stay hands-off in this branch for now since I'm not sure what state it's currently in. I think the API bump was required for the new Jetty, which seemed to help DLNA a lot. |
Updating libraries seemed to get DLNA working correctly, added jetty.server dependency as recommended by the jupnp website. Note: Jetty 9 must be used and has been updated to require MinSdkVersion to be changed to 26, this only seems to effect 1.4 percent of users based on apilevels.com
|
right. merged the API level 36 commit to. Now there is only the minSdk + library update left here. unfortunately I dont have any DLNA renderer to test with. Do you know something that can be installed on android/ linux? |
|
I think YAACC on fdroid should handle rendering. Also Kodi can do it, but takes a while to show up. Jetty required minsdk to be raised for me but that was only when I depended on the latest Jetty 9 as recommended by Jupnp. Possibly Jetty 9 2018 works but I didn't test it. |
2 participants
I have been using this as a daily runner on my old API 28 phone and tested with the API levels 26, 29, 32 and 35 via emulator.
Some things that appear to be fixed:
If there are any regressions please let me know and I'll commit fixes to this branch on my fork.