Ensure stale node views are updated and deletion does not cause flicker#60
Merged
philippjfr merged 3 commits intomainfrom Mar 26, 2026
Merged
Ensure stale node views are updated and deletion does not cause flicker#60philippjfr merged 3 commits intomainfrom
philippjfr merged 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the
nodeswas reflected correctly on the frontend but the views were not updated at the same time resulting in stale node views. Additionally since we updated nodes and edges in sequence there could be flicker on node deletion, usingholdwe ensure that these updates are reflected on the frontend simultaneously.