Draft
Conversation
Signed-off-by: Cristian Le <git@lecris.dev>
Contributor
|
❌ pre-commit FAILURE in 1m 55s |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the _payload_installability method in testing_farm.py to utilize a base payload helper, which simplifies the logic by removing manual environment configuration and dynamic reference fetching. Feedback was provided to replace hardcoded repository details with existing constants to ensure consistency and improve maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the cleanup of the current fedora-ci jobs https://forge.fedoraproject.org/ci/tickets/issues/553, the interface for all of these jobs would converge to that from packit, simplifying how the jobs are handled here.
TODO:
dist-git-branchfedora-ci/installability-pipeline#63