Run CI as a PHP version matrix on GitHub Actions - #43
Merged
Conversation
Jleagle
previously approved these changes
Sep 3, 2026
Replace the single containerised php-actions job (pinned to PHP 7.4) with a setup-php matrix over 7.4, 8.0, 8.1, 8.2, 8.3, 8.4 and 8.5, mirroring packaged/dal and extending it to current PHP. The lowest version matches the "php": ">=7.4" floor in composer.json. Triggers are narrowed to pushes to master and PRs targeting master; previously every push on every branch ran, double-running on PR branches. PHPUnit 8.5 emits "implicitly nullable parameter" deprecations from its own vendor code on PHP 8.4+, but they are raised at bootstrap and do not affect the exit code. Silencing them means moving to PHPUnit 9+, which is a separate change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
TomK
force-pushed
the
ci-actions-matrix
branch
from
September 3, 2026 13:56
ff0bab8 to
92d78f2
Compare
Jleagle
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI ran a single containerised
php-actionsjob pinned to PHP 7.4, so nothing above 7.4 was ever exercised despite the package being installable on 8.x. It also triggered on every push to every branch, which double-ran on PR branches.Now a
setup-phpmatrix over 7.4 / 8.0 / 8.1 / 8.2 withfail-fast: false, mirroringpackaged/dal. 7.4 is in there to cover the"php": ">=7.4"floor in composer.json. Triggers are pushes to master and PRs targeting master.No service containers or extra extensions — unlike dal, rwd has no ext or database requirements.
Test plan
Suite is green locally on PHP 7.4.33 and 8.2.33 (112 tests, 249 assertions). The one risky test —
UnknownTest::testTestCardsperforms no assertions — predates this change. Workflow YAML parses clean; the matrix legs themselves run on this PR.🤖 Generated with Claude Code