Skip to content

add renderLastLine method to overriding if it need - #71

Open
thykos wants to merge 1 commit into
pablosichert:masterfrom
thykos:renderLastLine
Open

add renderLastLine method to overriding if it need#71
thykos wants to merge 1 commit into
pablosichert:masterfrom
thykos:renderLastLine

Conversation

@thykos

@thykos thykos commented Oct 17, 2017

Copy link
Copy Markdown

I use this component to truncating a text, and I need to use react-linkify inside. I can override renderLine for this goals, but I noticed that last line rendered with broken link, because of slicing text.

@moubi

moubi commented Aug 10, 2018

Copy link
Copy Markdown
Contributor

@thykos does the change with renderLastLine actually make any functional difference?

@thykos

thykos commented Nov 1, 2018

Copy link
Copy Markdown
Author

@thykos does the change with renderLastLine actually make any functional difference?

yes, if we use linkify and last line include link, link will be cutted and broken. With renredLastLine we can prevent broke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants