fix: add QWT_FOUND guard in ld-analyse CMakeLists.txt#296
Open
Kraz3yIvan wants to merge 1 commit intooyvindln:vhs_decodefrom
Open
fix: add QWT_FOUND guard in ld-analyse CMakeLists.txt#296Kraz3yIvan wants to merge 1 commit intooyvindln:vhs_decodefrom
Kraz3yIvan wants to merge 1 commit intooyvindln:vhs_decodefrom
Conversation
Without a QWT_FOUND guard, the build fails on Windows when building with -DUSE_QWT=OFF because target_include_directories and target_link_libraries unconditionally reference QWT variables that are empty or undefined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without a QWT_FOUND guard, the build fails on Windows when
building without QWT (e.g. with -DUSE_QWT=OFF), because
target_include_directories and target_link_libraries
unconditionally reference QWT variables that are empty or
undefined.
This fix wraps the QWT-dependent include and link directives
in appropriate guards so the build succeeds cleanly with or
without QWT present.
Tested on Windows with -DUSE_QWT=OFF via MSYS2/MinGW64.