Add permissions and expiration date for public share#120
Closed
Add permissions and expiration date for public share#120
Conversation
Contributor
Author
|
requested in core: owncloud/core#18631 (comment) |
1 task
PVince81
force-pushed
the
publicshare-additionalattrs
branch
from
bbf79ef to
9c53dec
Compare
Contributor
Author
|
PVince81
force-pushed
the
publicshare-additionalattrs
branch
2 times, most recently
from
4c3eaef to
2d8b42e
Compare
PVince81
force-pushed
the
publicshare-additionalattrs
branch
from
2d8b42e to
a68cbcf
Compare
PVince81
force-pushed
the
publicshare-additionalattrs
branch
from
16aa340 to
63aed10
Compare
Contributor
Author
|
Rebased. Will still need the unit tests to be version conditional... |
Contributor
|
This PR now needs a lot of changes, I guess it is better to prepare a new one for being used with current master structure. |
Contributor
|
I've opened a follow up PR taking into account the new structure using shareinfo. #143 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119
@SergioBertolinSG
But requires expirationDate to be settable by core.
Also: