fix: run plugin beforeQuery hooks once#196
Open
Treasure520520 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/claim #71
This adds a focused regression slice for
StarbasePluginRegistry.beforeQuery()and fixes the covered hook-order bug.The registry was invoking each plugin's
beforeQuery()twice: once with the progressively modified SQL/params, then again with the original options. The second call could trigger duplicate plugin side effects while ignoring the chained SQL/param state. The registry now calls each hook once and passes the modified SQL/params to the next plugin in order.Verification
COREPACK_ENABLE_AUTO_PIN=0 corepack pnpm exec vitest --run src/plugin.test.tsCOREPACK_ENABLE_AUTO_PIN=0 corepack pnpm exec prettier --check src/plugin.ts src/plugin.test.tsgit diff --checkNote: the local commit used
--no-verifybecause.husky/pre-commitcalls a globalpnpmbinary that is not available in this shell. The same focused Corepack verification above passed after commit.