Skip to content

Add http method, and url to response log #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
otaviocc merged 1 commit into from
Oct 10, 2025
Merged

Add http method, and url to response log #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/MicroClient/NetworkClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@

// swiftlint:disable function_body_length

private func performRequest<ResponseModel>(

Check warning on line 59 in Sources/MicroClient/NetworkClient.swift

View workflow job for this annotation

GitHub Actions / SwiftLint 

Function should have complexity 10 or less; currently complexity is 12 (cyclomatic_complexity)
_ networkRequest: NetworkRequest<some Any, ResponseModel>,
attempt: Int
) async throws -> NetworkResponse<ResponseModel> {
Expand Down Expand Up @@ -106,7 +106,7 @@
}

if let httpResponse = response as? HTTPURLResponse {
log(.info, "Response: \(httpResponse.statusCode)")
log(.info, "Response: \(httpResponse.statusCode) \(urlRequest.httpMethod ?? "") \(urlRequest.url?.absoluteString ?? "")")

Check warning on line 109 in Sources/MicroClient/NetworkClient.swift

View workflow job for this annotation

GitHub Actions / SwiftLint 

Line should be 120 characters or less; currently it has 133 characters (line_length)
log(.debug, "Response headers: \(httpResponse.allHeaderFields)")

guard (200...299).contains(httpResponse.statusCode) else {
Expand Down