Conversation
leandrumartin
left a comment
There was a problem hiding this comment.
Looking god so far, but there are some things to clean up:
-
There is currently no delineation between bone and sub-bone.
If you take a look at the Bony Pelvis PowerPoint and how we are storing the data for that slideshow currently, you can see that the slideshow divides the information into 3 main sections for 3 bones: the ilium, the ischium, and the pubis. Each has several sub-bone regions associated with it. So in the current database, we have a
boneset/folder, abones/folder, and asubbones/folder storing basic hierarchical data for the bony pelvis boneset.The Skull PowerPoint is similarly divided into four sections: Anterior, Lateral, Inferior (base), and Superior (cavity), each with its own bones in that region. Although technically these are not bones and sub-bones, but rather different viewpoints of the skull and bones, we should be using the bone/sub-bone terminology so that we are storing and fetching the data consistently, and any changes needed in specific terminology can be handled on the front-end.
So, while right now for example you have both "cranial base" and "frontal bone" treated as "bones" in the hierarchy, the former should be a "bone" and the latter a "subbone."
Because the hierarchy is not yet correct in this PR, the "subbones" array for all of the bones is empty. This should be corrected according to the PowerPoint structure.
-
Also, several of the bones/subbones are missing; for example, you do not have a
mandible.json. -
The JSON files for the bones should not contain any description data. They exist only to list the name, ID, and sub-bones. Descriptions are instead supposed to be stored in their own dedicated JSON files (which you have already included).
-
None of the description JSONs have anything in the "images" array. It should be a list of filenames of images associated with the bone or sub-bone based on which image is present in the sub-bone's slide in the PowerPoint. If there are duplicates of the same image, you can only keep one and just list the appropriate filename in the images array.
Skulls Data/hierarchy.json
Outdated
There was a problem hiding this comment.
This file is unnnecessary
Let me know if the files I created are what you were looking for for the bone/sub-bones. I also added the images to the image array of the descriptions. |
Pull Request Summary
Closes #294
Extracts the data from Skull.pptx. I need to work on the hierarchical file. I think the others are right, but I need to double-check.
3/6/26 -
@leandrumartin All files should be correct with updated file names. Once approved, I can create another PR that merges into the data branch.