Skip to content

Multiply Divide#2

Open
DoraPancar wants to merge 5 commits into
mainfrom
multiply-divide
Open

Multiply Divide#2
DoraPancar wants to merge 5 commits into
mainfrom
multiply-divide

Conversation

@DoraPancar

Copy link
Copy Markdown
Collaborator

Multiplication and division functons are added

@osmanyasar05 osmanyasar05 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wont compile. please fix the issues.

Comment thread simpleCalculator.cpp Outdated
// result = YOUR_FUNCTION(a,b);
// }
// elif(oper == YOUR_OTHER_OPERATION).........
if (oper == multiply)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oper == multiply ?

multiply is not a variable. change it with oper == "*" and oper == "/"

Comment thread simpleCalculator.cpp Outdated
std::cout << a << " " << oper << " " << b << " = " << result;
}

double multiply(double a, double b)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functions should be defined before they are used. move these up.

@osmanyasar05 osmanyasar05 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants