fix: quote paths in buildV2VCommand to handle spaces in VM names#225
Open
miguelntt wants to merge 1 commit intoos-migrate:mainfrom
Open
fix: quote paths in buildV2VCommand to handle spaces in VM names#225miguelntt wants to merge 1 commit intoos-migrate:mainfrom
miguelntt wants to merge 1 commit intoos-migrate:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a VM name or script path contains spaces, the
virt-v2v-in-placecommand built bybuildV2VCommandfails because the shell interprets the spaces as argument separators. For example, a VM namedMy Virtual Machineproduces a disk path that when passed unquoted to the shell breaks the command.Fix
Wrap
path,rsPathandbsPathin single quotes insidebuildV2VCommand.extraOptsis intentionally left unquoted as it may contain multiple flags.Files changed
plugins/module_utils/nbdkit/nbdkit.go— 3 lines changed inbuildV2VCommand