-
Notifications
You must be signed in to change notification settings - Fork 6
dev: add start of CI section #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davidjpeacock
wants to merge
1
commit into
os-migrate:main
Choose a base branch
from
davidjpeacock:ci-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| [id="os-migrate-meta-ci-guide"] | ||
|
|
||
| = CI for OS Migrate Guide | ||
|
|
||
| There are four repositories for code for the OS Migrate project. | ||
|
|
||
| * os-migrate | ||
| * vmware-migration-kit | ||
| * documentation | ||
| * fake server (TBD) | ||
|
|
||
| The two software core repos, os-migrate, and vmware-migration-kit, have various test types available, listed below. | ||
|
|
||
| For the most part the Linters and Sanity tests are in place already, but there are gaps in unit testing that need to be filled. Additionally, functional tests need to be expanded. | ||
|
|
||
| A meta umbrella term in this project is End to End or E2E testing, which broadly speaking means Integration (and therefore functional) testing. | ||
|
|
||
| == Test Types | ||
|
|
||
| * Linters | ||
| ** Style check, syntax, format etc. | ||
| * Sanity | ||
| ** documentation in place, certifications, etc. | ||
| * Unit | ||
| ** Individual tests tied to specific code blocks | ||
| * Module | ||
| ** Module level testing | ||
| * Role | ||
| ** Role level testing | ||
| * Functional | ||
| ** Fit-for-purpose validations that prove working code externally, either via real connections or mocks & fakes | ||
| * Integration | ||
| ** Full validations against working systems, some real, some fakes | ||
|
|
||
| == Resource Requirements | ||
|
|
||
| A lot of the testing is trivial in scope and can be accomplised using existing GitHub Actions, at almost zero cost. However for larger E2E testing we require dedicated hardware. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are explaining what we do here, maybe we can write a bit more info here about the tests, so we arent vague. Hopefully this isnt an overkill, so let me know what you think.
then.... i am not sure where to put Module testing as you are describing it now (meaning: separate headers/topics). I would personally categorize module testing under either unit (testing single small targeted feature in module) or integration (stuff is working together/ idempotency).