chore(runtime): add profiling contracts and audit gates - #568
Conversation
|
Blocker 1 — package.json is broken and carries another branch's work Worse, the same hunk drops clsx and ali-react-table from dependencies — that's what most of the 472-line pnpm-lock.yaml churn is. No source file in this PR stops importing them. If anything still does, the build breaks; if nothing does, the removal belongs to whatever PR deleted those usages. Either way this is a chunk of a different branch that leaked in, and it has nothing to do with profiling. Blocker 2 — the PR is mislabeled, and it hides a wire-protocol rewrite Eight event channels collapse into one. agent://session-created, agent://session-deleted, agent://dialog-turn-{started,completed,cancelled,failed}, agent://token-usage-updated, agent://session-state-changed all become a single agent://event carrying {type, payload}. Mitigating, and worth telling the author: I searched the repo for agent:// and it appears in exactly three files — adapters/mock.rs, adapters/tauri.rs, and transport_tests.rs. Nothing under src/ subscribes to any of these channels. So this transport layer looks like unwired scaffolding and the rename is probably harmless today. Confirm locally before trusting that, since code search won't catch a dynamically-built channel name: rg -n "agent://" --hidden -g '!target' -g '!node_modules' What's genuinely good here Revert the package.json + pnpm-lock.yaml hunk entirely (or land the missing check-component-boundaries.mjs in the PR that removed the clsx/ali-react-table usages). |
9ec56d6 to
9e77f78
Compare
9e77f78 to
f715ca8
Compare
Problem
Runtime performance work lacks reproducible macOS/Rust memory profiling entry points, explicit heap-profiler lifecycle ownership, and validation that RPC/transport wire contracts remain measurable and type-safe.
Solution
Potential risks