fix(orgs): enforce root-cause-first org validation - #547
Open
beruro wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
An ORG2 Cloud invite URI previously reached the local
project_create_orgpath and was persisted as a realproject_orgsrow. The selector rendered that authoritative row correctly; filtering it in the UI would only hide the upstream invariant violation.Verification
cargo test -p project_management create_project_org --lib(4 passed)cargo check -p project_management --libcargo clippy -p project_management --librustfmt --edition 2021 --check src-tauri/crates/project-management/src/projects/io/orgs.rsgit diff --checkAudit notes
projects.db/project_orgsCreateProjectOrgRequest -> project_create_org -> create_project_orgclippy -D warningsremains blocked by a pre-existingtype_complexityfinding incrates/search/src/file/index_cache.rs; normal scoped clippy passes