Overwriting redirects with an item is no longer allowed#1072
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1072 +/- ##
==========================================
+ Coverage 56.42% 56.48% +0.06%
==========================================
Files 101 101
Lines 5069 5065 -4
Branches 2211 2208 -3
==========================================
+ Hits 2860 2861 +1
+ Misses 741 737 -4
+ Partials 1468 1467 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@veloman-yunkan How does the libzim behaves if we try to overwrite an item? I thought we should get rid of ASSERT!? #723 |
A
How does it apply to this PR? |
Fixes #1071
The PR mostly consists of new unit-tests demonstrating how attempts to overwrite existing entries work. Various combinations of the types of the existing entry and the entry being added are tested. The last commit eliminates the deliberate possibility of overwriting a redirection entry with an item entry, updating the unit tests correspondingly.