[change] Allow multiple jsonschema widgets in one page#333
[change] Allow multiple jsonschema widgets in one page#333nemesifier wants to merge 1 commit intomasterfrom
Conversation
Earlier the schema.json was bound to each view. No matter how many different switcher were present, it was only loading one of them. With this patch, fetching schema.json is bound to each switcher element. This allows fetching different JSONSchemas on the same page.
nemesifier
left a comment
There was a problem hiding this comment.
@pandafy I found a minor issue while testing the widget in the credentials edit page, can you replicate it?
@pandafy you're right, so I think we can merge this one. Do you agree? |
nemesifier
left a comment
There was a problem hiding this comment.
@pandafy shouldn't this line also be removed as part of this change?
pandafy
left a comment
There was a problem hiding this comment.
@pandafy shouldn't this line also be removed as part of this change?
Yes @nemesisdesign , you are right! 😄
We should than also remove this, otherwise test suite will fail.
openwisp-controller/openwisp_controller/connection/tests/test_admin.py
Lines 101 to 107 in fb6aa7e
|
@pandafy Thanks for your integration. I have also noticed the advanced mode code in the JS refers to an ID, but the CSS paths should be converted to use classes. |

Earlier the schema.json was bound to each view. No matter how many
different switcher were present, it was only loading one of them.
With this patch, fetching schema.json is bound to each switcher element.
This allows fetching different JSONSchemas on the same page.