[SDL] Enable Bandit B404 test#3913
Draft
jszczepa wants to merge 3 commits intoopenvinotoolkit:developfrom
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables Bandit’s B404 (“import subprocess”) check per SDL guidance, while suppressing B404 findings on specific subprocess imports.
Changes:
- Stop skipping Bandit B404 in
pyproject.toml. - Add inline
# nosec B404suppressions onsubprocessimports in two Python modules.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/nncf/torch/quantization/extensions.py | Suppresses Bandit B404 on subprocess import to keep scan green while B404 is enabled. |
| src/custom_version.py | Suppresses Bandit B404 on subprocess import to keep scan green while B404 is enabled. |
| pyproject.toml | Enables B404 by removing it from Bandit’s skip list (commented out). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5f6f71b to
af07577
Compare
a9625a6 to
128854f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This modification helps to apply SDL policy related to Bandit scans (see: https://github.com/intel-innersource/applications.security.bandit-config/blob/main/ipas_default.config)
Reason for changes
Each use of subprocess module need to be reviewed against cmd injection by potential attacker.
Related tickets
N/A
Tests
N/A