from_json no longer needed in gemma templates#4365
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Gemma chat templates to stop relying on from_json for tool-call arguments and to drop rendering of the response field in tool definitions, aligning the template output with the current tool-call/message structures used in OVMS LLM tests and examples.
Changes:
- Remove rendering of the
function.responseschema block from the Gemma tool declaration formatter. - Update the Gemma example template to render tool-call arguments directly as a mapping (no
from_jsonconversion) and adjust its header note accordingly. - Add a short “modifications” header comment to the test Gemma template for parity/clarity.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/test/llm/chat_templates/chat_template_gemma.jinja | Removes formatting for the response field in tool definitions and adds a short header note describing the modification. |
| extras/chat_template_examples/chat_template_gemma.jinja | Removes from_json usage and renders function['arguments'] directly when it is a mapping (retaining string fallback). |
dtrawins
approved these changes
Jul 10, 2026
mzegla
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.