added a memory-based Caffeine fetcher cache#347
Merged
Conversation
jdhayhurst
commented
Jun 2, 2026
Contributor
- Changed the fetcher cache from the simple cache (a hashmap) to a Caffeine implementation which prevents the cache from filling indefinitely.
- An upper global cache pool size is configurable which is then divided equally between the many (~20) fetcher caches - this means we will be over and underspending the cache allocation, but it keeps the implementation simple.
separate cache for each fetcher make cache method public so we can use in tests
remo87
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.