Fix default log level for Dataverse#109
Conversation
The Dataverse exporter crashes with "invalid choice: ''" when a CR
omits the logging section, because the empty Go zero value is passed
as --log-level "" [1].
Make the logging section default value an empty dict '{}' so OCP
always populates it with default values. Also, add a kubebuilder
default of "all=info" to ogxLogLevel and remove the runtime empty-string
fallback from getOGXLogLevel since the CRD now guarantees a value.
[1] 9f5e97b
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lpiwowar, umago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/test openstack-lightspeed-kuttl-4-18 Looks like an unrelated network issue: |
openshift-merge-bot
Bot
merged commit 34d4f23
into
openstack-lightspeed:lcore-migration
2 participants
The Dataverse exporter crashes with
invalid choice: ''when a CR omits the logging section, because the empty Go zero value is passed as --log-level "" [1].Make the logging section default value an empty dict '{}' so OCP always populates it with default values. Also, add a kubebuilder default of "all=info" to ogxLogLevel and remove the runtime empty-string fallback from getOGXLogLevel since the CRD now guarantees a value.
[1] 9f5e97b