Add Red Hat approved OpenStack operator icon#452
Conversation
11b86aa to
e99781c
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 00m 30s |
e99781c to
5d7a7d0
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 04m 42s |
|
recheck |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 46m 26s |
23ef8ae to
53e38d1
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 48m 03s |
|
LGTM but I'm waiting first for this review #454 |
|
like discussed with @posikoya yesterday on slack and commented on https://redhat.atlassian.net/browse/OSPRH-12506?focusedCommentId=17278628 , isn’t this obsolet since the test-operator was integrated in the openstack-operator with Add test operator into the openstack-operator-index by lpiwowar · Pull Request #752 · openstack-k8s-operators/openstack-operator and there is no dedicated/standalone install method for the test-operator? from what I see. we do not ship a bundle downstream for test-operator - https://catalog.redhat.com/en/search?q=test-operator . |
|
recheck |
Added the official, Red Hat-approved OpenStack operator icon to the ClusterServiceVersion manifest. The asset was sourced directly from an approved Red Hat site and encoded to Base64 to ensure the operator displays the logo correctly in the OperatorHub UI.
53e38d1 to
90c2c39
Compare
added the hold label as I think we should not need/land it, if I am wrong let me know. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: imatza-rh, posikoya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
@imatza-rh please check my previous comment |
Hey, I have no strong opinion from my side. The code change itself is lgtm (valid SVG, correct YAML placement), but I'll defer to you and @posikoya on whether it's needed given the downstream bundling situation. |
Added the official, Red Hat-approved OpenStack operator icon to the ClusterServiceVersion manifest. The asset was sourced directly from an approved Red Hat site and encoded to Base64 to ensure the operator displays the logo correctly in the OperatorHub UI.
used the link from: openstack-k8s-operators/openstack-operator#914 (comment) to render the image
Jira: OSPRH-12506