Closed
Conversation
Some variables are missing, especially related to the registry
credentials. That complicate the situation, where some keys
might not exists in reproducer file. Some of the variables
are jinja2 template, which are "translated" by Ansible.
Alternative way was to use yq command like:
yq eval-all -P 'select(fileIndex == 0) * select(fileIndex == 1)' \
/tmp/reproducer-variables.yml \
/home/zuul/configs/zuul_vars.yaml > merged.yaml
The yq is available in latest version available for current python3
version installed on hypervisor. In that case, we can not use
the yq tool, but use a python script.
Co-authored-by: Claude (AI Assistant) claude@anthropic.com
Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
Keep support for legacy workflow where controller host is created and actions are done not on hypervisor directly, but on controller. Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
On executing nested Ansible, some variables like: 'cifmw_registry_token' are not redirected, which is causing an issue in later tasks, which are operating on those variables and if it is undefine, it raise an issue. To satisfy nested Ansible execution, provide necessary variables. Also include hypervisor name as it can be a missing variable, due jobs already bootstrapped by ZIronic does not require to have that variable, which in some tasks is necessary. Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
The pull_secret.json might contain authentication to necessary registries for CI job, that are not available during the bootstrap process using PreMetal (earlier ZIronic).
Let's move all the tasks for pre job execution after PreMetal bootstrap. That would make reproducer playbook easier to read. Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This change depends on a change that failed to merge. Change #3794 is needed. |
Contributor
Author
|
recheck |
Worth to try, if we can skip sync secrets with controller-0 to avoid potential leak. Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
danpawlik
force-pushed
the
drop-secret-sync
branch
from
6018841 to
c175436
Compare
Contributor
Author
|
can't go with that approach, due: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worth to try, if we can skip sync secrets with controller-0 to avoid potential leak.
post-action-for: #3794