OCPBUGS-87390: Updating ose-service-ca-operator-container image to be consistent with ART for 5.0#361
Conversation
|
Created by ART pipeline job run https://art-jenkins.apps.prod-stable-spoke1-dc-iad2.itup.redhat.com/job/aos-cd-builds/job/build%252Fsync-ci-images/201 |
WalkthroughThe PR updates container build images used by the OpenShift service CA operator. The CI operator build configuration tag is bumped to use Go 1.26 on OpenShift 5.0. The Dockerfile.rhel7 multi-stage build is updated to match: the builder stage uses the newer OpenShift builder image, and the final runtime base is updated from OpenShift 4.22 to 5.0. ChangesBuild Configuration Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 1 warning)
✅ Passed checks (13 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-87390, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-87390, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Dockerfile.rhel7 (1)
8-15:⚠️ Potential issue | 🟠 Major | ⚡ Quick winFinal image still runs as root (missing non-root
USER).There is no
USERdirective in the runtime stage, so the container runs as root by default. Add a non-root user in the final stage and ensure copied artifacts are readable/executable by that UID.As per coding guidelines, "USER non-root; never run as root."Suggested hardening patch
FROM registry.ci.openshift.org/ocp/5.0:base-rhel9 COPY --from=builder /go/src/github.com/openshift/service-ca-operator/service-ca-operator /usr/bin/ COPY --from=builder /go/src/github.com/openshift/service-ca-operator/service-ca-operator-tests-ext.gz /usr/bin/ COPY manifests /manifests # Using the vendored CRD ensures compatibility with 'oc explain' COPY vendor/github.com/openshift/api/operator/v1/zz_generated.crd-manifests/0000_50_service-ca_02_servicecas.crd.yaml /manifests/02_crd.yaml +USER 1001 ENTRYPOINT ["/usr/bin/service-ca-operator"] LABEL io.openshift.release.operator=true🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Dockerfile.rhel7` around lines 8 - 15, The final image runs as root because the runtime stage lacks a non-root USER; update the final stage (the lines around ENTRYPOINT ["/usr/bin/service-ca-operator"] and the copied artifacts service-ca-operator and service-ca-operator-tests-ext.gz and /manifests/02_crd.yaml) to create or use a non-root UID/GID, set file ownership/permissions so the binary and manifests are readable/executable by that UID, and add a USER <uid> directive before ENTRYPOINT so the container doesn't run as root. Ensure the created UID owns /usr/bin/service-ca-operator and any required dirs (or use chown/chmod) and confirm the binary is executable by that user.Sources: Coding guidelines, Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Dockerfile.rhel7`:
- Line 1: The Dockerfile uses CI registry base images (the FROM line with
"registry.ci.openshift.org/... AS builder") which violates the container policy;
update both Dockerfile stages (the "builder" stage and the final run stage) to
use approved production UBI/distroless images from catalog.redhat.com (or
another approved production registry) instead of CI images, or add a documented
policy exception in the repository explaining why CI images are required for
this build; ensure the replacement images preserve required toolchain (Go
runtime/toolchain) and adjust any build steps accordingly.
---
Outside diff comments:
In `@Dockerfile.rhel7`:
- Around line 8-15: The final image runs as root because the runtime stage lacks
a non-root USER; update the final stage (the lines around ENTRYPOINT
["/usr/bin/service-ca-operator"] and the copied artifacts service-ca-operator
and service-ca-operator-tests-ext.gz and /manifests/02_crd.yaml) to create or
use a non-root UID/GID, set file ownership/permissions so the binary and
manifests are readable/executable by that UID, and add a USER <uid> directive
before ENTRYPOINT so the container doesn't run as root. Ensure the created UID
owns /usr/bin/service-ca-operator and any required dirs (or use chown/chmod) and
confirm the binary is executable by that user.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: ba5d5140-cec5-4a00-9012-4257dc34d94c
📒 Files selected for processing (2)
.ci-operator.yamlDockerfile.rhel7
| @@ -1,11 +1,11 @@ | |||
| FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.25-openshift-4.22 AS builder | |||
| FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.26-openshift-5.0 AS builder | |||
There was a problem hiding this comment.
Use approved production base images per container policy.
The updated FROM images are CI registry images, not UBI minimal/distroless from catalog.redhat.com as required by the Dockerfile security guideline. Please switch both stages to approved production base images (or document an explicit policy exception for this repo if CI images are intentionally mandated).
Also applies to: 8-8
🧰 Tools
🪛 Trivy (0.69.3)
[error] 1-1: Image user should not be 'root'
Specify at least 1 USER command in Dockerfile with non-root user as argument
Rule: DS-0002
(IaC/Dockerfile)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Dockerfile.rhel7` at line 1, The Dockerfile uses CI registry base images (the
FROM line with "registry.ci.openshift.org/... AS builder") which violates the
container policy; update both Dockerfile stages (the "builder" stage and the
final run stage) to use approved production UBI/distroless images from
catalog.redhat.com (or another approved production registry) instead of CI
images, or add a documented policy exception in the repository explaining why CI
images are required for this build; ensure the replacement images preserve
required toolchain (Go runtime/toolchain) and adjust any build steps
accordingly.
Source: Coding guidelines
|
@openshift-bot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
ART wants to connect issue OCPBUGS-87676 to this PR, but found it is currently hooked up to ['OCPBUGS-87390']. Please consult with #forum-ocp-art if it is not clear what there is to do. |
openshift-bot
added
the
verified
3 participants
Updating ose-service-ca-operator-container image to be consistent with ART for 5.0
TLDR:
Product builds by ART can be configured for different base and builder images than corresponding CI
builds. This automated PR requests a change to CI configuration to align with ART's configuration;
please take steps to merge it quickly or contact ART to coordinate changes.
The configuration in the following ART component metadata is driving this alignment request:
ose-service-ca-operator.yml.
Detail:
This repository is out of sync with the downstream product builds for this component. The CI
configuration for at least one image differs from ART's expected product configuration. This should
be addressed to ensure that the component's CI testing accurate reflects what customers will
experience.
Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a
different version, usually prior to GA. The intent is to effect changes in both configurations
simultaneously without breaking either CI or ART builds, so usually ART builds are configured to
consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may
also configure changes in GA releases with CI remaining canonical for a brief grace period to enable
CI to succeed and the alignment PR to merge. In either case, ART configuration will be made
canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is
important to align CI configuration as soon as possible.
PRs are also triggered when CI configuration changes without ART coordination, for instance to
change the number of builder images or to use a different golang version. These changes should be
coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated
first to enable the changes to occur simultaneously in both CI and ART at the same time. This also
gives ART a chance to validate the intended changes first. For instance, ART compiles most
components with the Golang version being used by the control plane for a given OpenShift release.
Exceptions to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift staff engineers and
communicated to the ART team.
Roles & Responsibilities:
tests OR that necessary metadata changes are reported to the ART team
in
#forum-ocp-arton Slack. If necessary, the changes required by this pull request can beintroduced with a separate PR opened by the component team. Once the repository is aligned,
this PR will be closed automatically.
verify-depsis complaining. In that case, please opena new PR with the dependency issues addressed (and base images bumped). ART-9595 for reference.
any required labels to ensure the PR merges once tests are passing. In cases where ART config is
canonical, downstream builds are already being built with these changes, and merging this PR
only improves the fidelity of our CI. In cases where ART config is not canonical, this provides
a grace period for the component team to align their CI with ART's configuration before it becomes
canonical in product builds.
ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:
Change behavior of future PRs:
set up automatically. This means that such a PR would merge without human intervention (and awareness!) in the future.
To do so, open a PR to set the
auto_labelattribute in the image configuration. ExampleUPSTREAM: <carry>:. An example.If you have any questions about this pull request, please reach out in the
#forum-ocp-artSlack channel.