OCPBUGS-74511: remove RouteExternalCertificate feature gate

[jcmoraisjr]

RouteExternalCertificate featuregate now is enabled by default. cluster-ingress-operator configures the router adding ROUTER_ENABLE_EXTERNAL_CERTIFICATE envvar with the featuregate state. This update is removing the read of this envvar, and the behavior is hardcoded as the provided value was true.

[openshift-ci-robot]

@jcmoraisjr: This pull request references Jira Issue OCPBUGS-74511, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

RouteExternalCertificate featuregate now is enabled by default. cluster-ingress-operator configures the router adding ROUTER_ENABLE_EXTERNAL_CERTIFICATE envvar with the featuregate state. This update is removing the read of this envvar, and the behavior is hardcoded as the provided value was true.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ironcladlou for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[melvinjoseph86]

Marking this PR as verified as this openshift/cluster-ingress-operator#1355 (comment)
/verified by @mjoseph

[openshift-ci-robot]

@melvinjoseph86: This PR has been marked as verified by @mjoseph.

Details

In response to this:

Marking this PR as verified as this openshift/cluster-ingress-operator#1355 (comment)
/verified by @mjoseph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jcmoraisjr]

/retest

[openshift-ci]

@jcmoraisjr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.