WIP: AUTOSCALE-971: Run HTTP Add-on e2e tests in CMA operator CI - #84156
WIP: AUTOSCALE-971: Run HTTP Add-on e2e tests in CMA operator CI#84156linkvt wants to merge 1 commit into
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@linkvt: This pull request references AUTOSCALE-971 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. WalkthroughChangesHTTP Add-on end-to-end testing
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds HTTP Add-on end-to-end coverage to CMA operator CI, and no actionable merge-blocking risk remains beyond normal checks and review. Sequence Diagram(s)sequenceDiagram
participant CMAWorkflow
participant HTTPAddonSetup
participant OpenShiftCluster
participant HTTPAddonRun
participant TestImage
CMAWorkflow->>HTTPAddonSetup: run external dependency setup
HTTPAddonSetup->>TestImage: invoke make e2e-deps-external
TestImage->>OpenShiftCluster: install e2e dependencies
CMAWorkflow->>HTTPAddonRun: run HTTP Add-on e2e suite
HTTPAddonRun->>TestImage: invoke make e2e-test-openshift-ci
TestImage->>OpenShiftCluster: execute e2e tests
🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (7 skipped: 7 unsupported.) Full details: Stable And Deterministic Test NamesExplanation PASS: The pull request adds CI step references, shell wrappers, ownership metadata, and two static workflow refs. It adds no Full details: Test Structure And QualityExplanation PASS: The pull request changes only CI YAML, step metadata, OWNERS files, and two strict-mode shell wrappers. The diff contains no Ginkgo test code or It/BeforeEach/AfterEach/Eventually/Consistently/Expect assertions. Therefore the listed Ginkgo test-structure requirements are not applicable, and the new wrappers delegate execution to the external Full details: Microshift Test CompatibilityExplanation PASS: The pull request adds CI step definitions and shell wrappers only. The commit diff contains no Go or Ginkgo test changes and no references to OpenShift APIs, namespaces, or MicroShift-sensitive features. The new run step invokes a prebuilt external test image; this check does not flag tests that are not added or modified in the pull request. Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The pull request adds CI orchestration and step metadata only. The diff contains no new Ginkgo test declarations or test implementation. It invokes the existing HTTP Add-on suite from a prebuilt image and adds no node, topology, affinity, replica, failover, or rescheduling assumptions. Full details: Topology-Aware Scheduling CompatibilityExplanation PASS: The pull request changes only CI workflow wiring, CI step metadata, ownership files, and shell wrappers. The added step YAML declares an image, CPU request, and an image dependency, but no anti-affinity, topology spread constraint, replica count, node selector/affinity, toleration, or PDB. The exact diff contains no operator code or deployment/controller manifest changes. Therefore, it introduces no scheduling constraint covered by this check. Full details: Ote Binary Stdout ContractExplanation No OTE binary source changed. The commit changes CI YAML, OWNERS, metadata, and two shell wrappers. The wrappers only invoke Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation FAIL: The PR adds Resolution IPv6 and disconnected network compatibility notice: This test may contain IPv4 assumptions or external connectivity requirements that will fail in IPv6-only disconnected environments. Please verify your test works on IPv6 by running an additional CI job: For parallel tests: Full details: No-Weak-CryptoExplanation PASS: The pull request adds CI step references, metadata, ownership files, and shell wrappers that only invoke Full details: Container-PrivilegesExplanation No prohibited privilege configuration is introduced. The changed CI workflow only adds two step references, and both new step-reference YAML files define the image, commands, CPU request, dependency, and documentation. They contain no Full details: No-Sensitive-Data-In-LogsExplanation No sensitive-data logging is introduced. The changed scripts only run
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: linkvt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Extends the CMA operator's cma-e2e-aws-ovn test to also install the HTTP Add-on (via the shared KedaController CR alongside KEDA) and run its e2e suite, so HTTP Add-on failures surface in CMA operator CI and not just in the standalone kedacore-http-add-on CI. Signed-off-by: Vincent Link <vlink@redhat.com>
115ae56 to
b81c1e4
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
1 similar comment
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-e2e-aws-ovn |
|
@linkvt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@linkvt: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Depends on all related PRs:
Extends the CMA operator's cma-e2e-aws-ovn test to also install the HTTP Add-on (via the shared KedaController CR alongside KEDA) and run its e2e suite, so HTTP Add-on failures surface in CMA operator CI and not just in the standalone kedacore-http-add-on CI.
Also add steps to run the HTTP Addon E2E tests.
make updatewas run before this commit.Summary by CodeRabbit
This PR extends CMA operator OpenShift CI coverage. The
cma-e2e-aws-ovnworkflow now installs the HTTP Add-on through the sharedKedaControllerresource and runs the HTTP Add-on end-to-end tests.The new CI steps install external test dependencies and run
make e2e-test-openshift-ciwith the required gRPC echo image. This exposes HTTP Add-on failures in CMA operator CI.