Test GCP bastion host

[arkadeepsen]

Summary by CodeRabbit

• Updated the GCP bastion host provisioning command script used by OpenShift CI infrastructure.
• Added spacing after the retry loop in the custom endpoint accessibility check.
• No functional behavior changed.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arkadeepsen
Once this PR has been reviewed and has the lgtm label, please assign rochacbruno for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/gcp/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 71e0954b-f7fe-4b29-b9e0-008d8a854601

📥 Commits

Reviewing files that changed from the base of the PR and between ace104d and 99dae6a.

📒 Files selected for processing (1)

• ci-operator/step-registry/gcp/provision/bastionhost/gcp-provision-bastionhost-commands.sh

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

Walkthrough

The change adds two blank lines after the retry loop and set -e in the GCP custom endpoint accessibility check. No functional logic changes.

Changes

GCP bastion host provisioning

Layer / File(s)	Summary
Custom endpoint check formatting ci-operator/step-registry/gcp/provision/bastionhost/gcp-provision-bastionhost-commands.sh	Adds blank lines after the retry loop and set -e.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 99dae

This is a narrowly scoped change with no actionable merge-blocking risk remaining beyond normal checks and review.

Suggested reviewers: redhat-chai-bot

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title claims that the pull request tests a GCP bastion host, but the changes only add blank lines and do not modify test or provisioning behavior.	Use a title that describes the formatting-only change, or update the pull request to include the intended GCP bastion host test changes.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request changes only one shell script and adds blank lines after set -e. The exact diff introduces no Ginkgo test or test-title expression. Therefore, it does not introduce unstable o…
Test Structure And Quality	✅ Passed	PASS: The pull request changes only one shell script, gcp-provision-bastionhost-commands.sh, by adding a blank line after set -e. The diff contains no Ginkgo test code or test declarations. Theref…
Microshift Test Compatibility	✅ Passed	PASS: The pull request changes only one shell script by adding a blank line. The commit adds no Ginkgo test declarations or markers, and the diff is empty when whitespace and blank lines are ignored. …
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request changes only gcp-provision-bastionhost-commands.sh by adding blank lines after set -e in an existing shell retry block. The parent-to-HEAD diff contains no new Ginkgo tests …
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request changes only one shell script, adding blank lines after set -e. The exact diff introduces no deployment manifest, operator code, controller, or scheduling constraint. The chan…
Ote Binary Stdout Contract	✅ Passed	PASS: The pull request changes only ci-operator/step-registry/gcp/provision/bastionhost/gcp-provision-bastionhost-commands.sh. The diff adds one blank line after set -e and changes no Go code, OTE…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The pull request changes only one blank line in ci-operator/step-registry/gcp/provision/bastionhost/gcp-provision-bastionhost-commands.sh. The parent-to-HEAD diff contains no new Ginkgo test a…
No-Weak-Crypto	✅ Passed	PASS. The pull request changes only whitespace: it adds one blank line after set -e in the retry block. The added lines contain no MD5, SHA1, DES, RC4, Blowfish, ECB, custom cryptography, or secret …
Container-Privileges	✅ Passed	PASS: The pull request changes only gcp-provision-bastionhost-commands.sh by adding blank lines after set -e. The diff adds no container or Kubernetes manifest and introduces none of privileged,…
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The pull request changes only one blank line in gcp-provision-bastionhost-commands.sh. The exact diff adds an empty line after set -e; it adds no logging statement, output value, or sensitiv…

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

Full details: Stable And Deterministic Test Names

Explanation

PASS: The pull request changes only one shell script and adds blank lines after set -e. The exact diff introduces no Ginkgo test or test-title expression. Therefore, it does not introduce unstable or dynamic test names.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only one shell script, gcp-provision-bastionhost-commands.sh, by adding a blank line after set -e. The diff contains no Ginkgo test code or test declarations. Therefore, the listed Ginkgo quality requirements are not applicable, and no failure condition is introduced.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request changes only one shell script by adding a blank line. The commit adds no Ginkgo test declarations or markers, and the diff is empty when whitespace and blank lines are ignored. Therefore, the MicroShift test compatibility check is not applicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request changes only gcp-provision-bastionhost-commands.sh by adding blank lines after set -e in an existing shell retry block. The parent-to-HEAD diff contains no new Ginkgo tests or test declarations, so the SNO compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only one shell script, adding blank lines after set -e. The exact diff introduces no deployment manifest, operator code, controller, or scheduling constraint. The changed script provisions a GCP bastion VM and checks endpoint accessibility, so the topology-aware scheduling check is not applicable.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The pull request changes only ci-operator/step-registry/gcp/provision/bastionhost/gcp-provision-bastionhost-commands.sh. The diff adds one blank line after set -e and changes no Go code, OTE binary, or process-level stdout behavior. The custom check is therefore not applicable.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request changes only one blank line in ci-operator/step-registry/gcp/provision/bastionhost/gcp-provision-bastionhost-commands.sh. The parent-to-HEAD diff contains no new Ginkgo test and no changed networking or connectivity logic. The custom check is therefore not applicable.

Full details: No-Weak-Crypto

Explanation

PASS. The pull request changes only whitespace: it adds one blank line after set -e in the retry block. The added lines contain no MD5, SHA1, DES, RC4, Blowfish, ECB, custom cryptography, or secret comparison logic.

Full details: Container-Privileges

Explanation

PASS: The pull request changes only gcp-provision-bastionhost-commands.sh by adding blank lines after set -e. The diff adds no container or Kubernetes manifest and introduces none of privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation. No flagged privilege condition is introduced.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The pull request changes only one blank line in gcp-provision-bastionhost-commands.sh. The exact diff adds an empty line after set -e; it adds no logging statement, output value, or sensitive-data handling. Existing credential-related commands and proxy URL file writes are unchanged and are not caused by this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@arkadeepsen: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-gcp-pd-csi-driver-operator-release-4.22-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver-operator	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-operator-release-4.21-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver-operator	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-operator-release-4.20-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver-operator	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-operator-release-4.19-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver-operator	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-operator-release-4.18-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver-operator	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-operator-release-4.17-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver-operator	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-operator-release-4.16-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver-operator	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-operator-release-4.15-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver-operator	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-operator-release-4.14-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver-operator	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-master-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-release-5.2-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-release-5.1-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-release-5.0-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-release-4.23-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-release-4.22-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-release-4.21-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-release-4.20-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-release-4.19-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-release-4.18-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-release-4.17-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-release-4.16-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-release-4.15-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver	presubmit	Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-release-4.14-e2e-gcp-csi-extended	openshift/gcp-pd-csi-driver	presubmit	Registry content changed
pull-ci-openshift-csi-operator-release-5.0-e2e-gcd-csi	openshift/csi-operator	presubmit	Registry content changed
pull-ci-openshift-csi-operator-main-e2e-gcp-csi-extended	openshift/csi-operator	presubmit	Registry content changed

A total of 652 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[arkadeepsen]

Checking if the changes in #83435 is causing the below tests to fail or not.

/pj-rehearse pull-ci-openshift-csi-operator-main-e2e-gcp-csi-extended pull-ci-openshift-installer-main-gcp-private

[openshift-merge-bot]

@arkadeepsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@arkadeepsen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/csi-operator/main/e2e-gcp-csi-extended	99dae6a	link	unknown	/pj-rehearse pull-ci-openshift-csi-operator-main-e2e-gcp-csi-extended

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.