Skip to content

[ROSAENG-61879] adding rosa-e2e int testing - #84059

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bmeng:int-ci
Aug 26, 2026
Merged

[ROSAENG-61879] adding rosa-e2e int testing#84059
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bmeng:int-ci

Conversation

@bmeng

@bmeng bmeng commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

adding one integration rosa-e2e testing

Summary by CodeRabbit

  • Updates OpenShift CI configuration for the openshift-online/rosa-e2e repository.
  • Adds ROSA HCP E2E periodic jobs for stable releases 4.20, 4.21, and 4.22, plus candidate release 5.0.
  • Changes the staging HCP periodic from the nightly channel to the candidate channel.
  • Normalizes the integration login environment to int when constructing ROSA HCP namespaces.
  • Schedules the jobs to rehearse ROSA HCP E2E integration workflows on main.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 17817250-cbeb-44b5-b5a9-7e7227d4d56e

📥 Commits

Reviewing files that changed from the base of the PR and between 142f76e and ae92b81.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__periodics.yaml
  • ci-operator/step-registry/rosa/cluster/wait-ready/hosted-cp/rosa-cluster-wait-ready-hosted-cp-commands.sh
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__periodics.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The periodic configuration changes staging HCP 5.0 to the candidate channel, adds integration-environment HCP jobs for OpenShift 4.20–4.22 and candidate 5.0, and normalizes integration namespace names.

Changes

ROSA HCP periodic coverage

Layer / File(s) Summary
HCP periodic schedules and channels
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__periodics.yaml
The staging HCP 5.0 periodic uses the candidate channel. Four integration-environment periodics cover stable 4.20–4.22 and candidate 5.0 releases.
Integration namespace normalization
ci-operator/step-registry/rosa/cluster/wait-ready/hosted-cp/rosa-cluster-wait-ready-hosted-cp-commands.sh
Namespace generation maps OCM_LOGIN_ENV=integration to int and uses the normalized value for HC and HCP namespaces.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ae92b

This PR adds ROSA end-to-end integration testing and related CI updates; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: dustman9000, jfrazierredhat

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the addition of ROSA E2E integration testing and matches the main changes in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The custom check "Stable and Deterministic Test Names" requires flagging Ginkgo test names (It(), Describe(), Context(), When(), etc.) that contain dynamic information such as generated identifiers, t…
Test Structure And Quality ✅ Passed PASS: The pull request changes only periodic YAML configuration, generated Prow jobs, and a shell namespace mapping. The diff contains no Ginkgo test code, It blocks, resource fixtures, or Eventually/…
Microshift Test Compatibility ✅ Passed The custom check for MicroShift Test Compatibility applies to "When new Ginkgo e2e tests are added (It(), Describe(), Context(), When(), etc.)". This PR does not add any Ginkgo e2e test code. The PR c…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request adds periodic ROSA job configuration and namespace normalization only. The complete diff changes two YAML files and one shell script; it adds no Ginkgo test declarations or Go/t…
Topology-Aware Scheduling Compatibility ✅ Passed The check is not triggered by this pull request. The diff adds periodic CI configuration and generated ProwJob objects, plus namespace normalization in a readiness shell script. The added job specs in…
Ote Binary Stdout Contract ✅ Passed PASS. The pull request changes only two YAML job/configuration files and one ROSA shell step. The added code creates integration job definitions and normalizes the namespace token from integration t…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The custom check "IPv6 and Disconnected Network Test Compatibility" specifies that it applies "when new Ginkgo e2e tests are added (It(), Describe(), Context(), When(), etc.)". Investigation confirms …
No-Weak-Crypto ✅ Passed The custom check "no-weak-crypto" requires flagging MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB mode usage; custom crypto implementations; and non-constant-time secret comparisons. Investigation findings…
Container-Privileges ✅ Passed The pull request adds CI configuration for new ROSA E2E integration tests and updates a shell script for namespace handling. The changes do not introduce any container privilege escalation settings. C…
No-Sensitive-Data-In-Logs ✅ Passed The pull request adds ROSA E2E integration tests and modifies a shell script to normalize the OCM environment token in namespace names. The custom check requires detection of logging that exposes pass…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

The custom check "Stable and Deterministic Test Names" requires flagging Ginkgo test names (It(), Describe(), Context(), When(), etc.) that contain dynamic information such as generated identifiers, timestamps, pod names with suffixes, or other runtime-specific values. The check does not apply to this PR because no Ginkgo test code is modified. The PR contains only CI/CD configuration changes (two YAML files with periodic job definitions) and a shell script modification for namespace construction in a deployment script. No test title declarations are introduced, modified, or removed.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only periodic YAML configuration, generated Prow jobs, and a shell namespace mapping. The diff contains no Ginkgo test code, It blocks, resource fixtures, or Eventually/Consistently calls. Therefore, the listed Ginkgo test-structure requirements are not applicable to the changed code.

Full details: Microshift Test Compatibility

Explanation

The custom check for MicroShift Test Compatibility applies to "When new Ginkgo e2e tests are added (It(), Describe(), Context(), When(), etc.)". This PR does not add any Ginkgo e2e test code. The PR contains only CI configuration changes (20 YAML files, 3 shell scripts) and modifies OpenShift CI workflow definitions for ROSA E2E testing. No Go test files or Ginkgo test definitions are introduced. The actual ROSA E2E tests come from a separate base image built from the openshift-rosa-e2e repository, not from this PR. Therefore, the MicroShift Test Compatibility check is not applicable to this pull request.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request adds periodic ROSA job configuration and namespace normalization only. The complete diff changes two YAML files and one shell script; it adds no Ginkgo test declarations or Go/test files. Therefore, the SNO multi-node compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

The check is not triggered by this pull request. The diff adds periodic CI configuration and generated ProwJob objects, plus namespace normalization in a readiness shell script. The added job specs introduce no node selectors, affinity or anti-affinity, topology spread constraints, tolerations, PDBs, or deployment replica strategies. The shell change only maps integration to int for namespace names and does not create or configure workloads.

Full details: Ote Binary Stdout Contract

Explanation

PASS. The pull request changes only two YAML job/configuration files and one ROSA shell step. The added code creates integration job definitions and normalizes the namespace token from integration to int. The diff adds no OTE binary source, Ginkgo suite setup, klog, or process-level fmt.Print/logging code. The shell script's existing echo-based log() function is outside the check's OTE process-level scope, and the changed lines do not add stdout writes.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

The custom check "IPv6 and Disconnected Network Test Compatibility" specifies that it applies "when new Ginkgo e2e tests are added (It(), Describe(), Context(), When(), etc.)". Investigation confirms that this pull request does NOT add any new Ginkgo e2e tests. The three modified files are: 1. ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__periodics.yaml - A CI/CD configuration file (YAML) that adds periodic job definitions. These are job scheduling configurations, not test code. 2. ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-periodics.yaml - A generated CI/CD job configuration file (YAML). 3. ci-operator/step-registry/rosa/cluster/wait-ready/hosted-cp/rosa-cluster-wait-ready-hosted-cp-commands.sh - A shell utility script that maps OCM_LOGIN_ENV=integration to namespace token int. This is infrastructure code, not a Ginkgo test. No Go source files (*.go) were added or modified. No Ginkgo test definitions (It(), Describe(), Context(), When()) appear in the changes. The PR adds CI/CD job configuration that references an existing rosa-e2e-hcp workflow, but does not define new Ginkgo tests. Since the custom check explicitly applies only when new Ginkgo e2e tests are added, and no such tests are added in this PR, the check is not applicable.

Full details: No-Weak-Crypto

Explanation

The custom check "no-weak-crypto" requires flagging MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB mode usage; custom crypto implementations; and non-constant-time secret comparisons. Investigation findings: 1. Modified Files: The pull request changes two files: - ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__periodics.yaml — Adds ROSA E2E integration test job configurations - ci-operator/step-registry/rosa/cluster/wait-ready/hosted-cp/rosa-cluster-wait-ready-hosted-cp-commands.sh — Updates namespace mapping logic for the OCM_LOGIN_ENV variable 2. Cryptographic Algorithm Scanning: Searched both files for weak cryptographic patterns (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB). No matches found. Incidental matches for "des" and "ec" are parts of normal words like "description" in logging statements, not cryptographic identifiers. 3. Cryptographic Library Usage: Searched for imports or invocations of cryptography libraries (crypto, cipher, hash, encrypt, decrypt, openssl, gpg, aes, sha256, sha512, rsa, ecdsa). No cryptographic libraries are used in either file. 4. Secret or Token Comparisons: The shell script performs string comparisons (e.g., [[ "${MC_NAME}" == "null" ]], [[ "${HC_AVAILABLE}" == "True" ]]), but these compare status values and cluster names, not cryptographic secrets or authentication tokens. The script uses jq to parse JSON from the OCM API, but does not implement custom constant-time comparisons. 5. File Purpose: The YAML file contains CI/CD job configuration; the shell script performs Kubernetes cluster readiness validation. Neither file introduces cryptographic operations or implementations. No explicit failure conditions specified in the custom check have been introduced by this pull request.

Full details: Container-Privileges

Explanation

The pull request adds CI configuration for new ROSA E2E integration tests and updates a shell script for namespace handling. The changes do not introduce any container privilege escalation settings. Container specifications in the generated ProwJob manifests use standard, non-privileged configurations with no privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN capabilities, allowPrivilegeEscalation: true, or related privilege escalation vectors. All volume mounts are read-only. No security-context related modifications that would violate the container-privileges check are present in this pull request.

Full details: No-Sensitive-Data-In-Logs

Explanation

The pull request adds ROSA E2E integration tests and modifies a shell script to normalize the OCM environment token in namespace names. The custom check requires detection of logging that exposes passwords, tokens, API keys, PII (email, SSN, credit card), session IDs, internal hostnames, or customer data. Investigation findings: 1. YAML configuration changes: The PR adds four new periodic job definitions for integration-environment HCP tests (stable 4.20, 4.21, 4.22, and candidate 5.0) and changes one staging job's channel from nightly to candidate. These configuration files contain only non-sensitive environment variables: CHANNEL_GROUP, CLUSTER_SECTOR, ENABLE_BILLING_ACCOUNT, HOSTED_CP, LABEL_FILTER, OCM_LOGIN_ENV (set to "integration"), OPENSHIFT_VERSION, REGION, and REPLICAS. 2. Shell script changes: The PR modifies rosa-cluster-wait-ready-hosted-cp-commands.sh to normalize OCM_LOGIN_ENV="integration" to a short token "int" for use in Kubernetes namespace names. The namespace names logged (lines 83-84) contain: ocm-<env>-<cluster_id>[-<cluster_name>]. These are internal identifiers, not secrets. 3. No credential logging introduced: The PR does not introduce logging of SSO_CLIENT_SECRET, OCM_TOKEN, or any other authentication credentials. The existing ocm login commands that use credentials (lines 26 and 29) are unchanged and were already present in the codebase. 4. No sensitive data types exposed: The changes do not introduce logging of passwords, tokens, API keys, credit card numbers, SSNs, email addresses, session IDs, or customer data. The namespace names themselves are infrastructure-level identifiers, not sensitive customer or authentication data. The pull request introduces no new logging of the sensitive data types specified in the check definition.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2026
@bmeng

bmeng commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-periodics-integration-rosa-hcp-e2e-integration-nightly-5-0

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@bmeng

bmeng commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-22 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-candidate-5-0 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-21 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-20

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@bmeng

bmeng commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-22 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-candidate-5-0 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-21 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-20

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bmeng

bmeng commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-22

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@bmeng

bmeng commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-22 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-candidate-5-0 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-21 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-20

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@bmeng: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-online-rosa-e2e-main-e2e-rosa-hcp-smoke openshift-online/rosa-e2e presubmit Registry content changed
pull-ci-openshift-route-monitor-operator-master-rosa-hcp-mc-e2e openshift/route-monitor-operator presubmit Registry content changed
pull-ci-openshift-aws-vpce-operator-main-rosa-hcp-mc-e2e openshift/aws-vpce-operator presubmit Registry content changed
periodic-ci-openshift-route-monitor-operator-master-rosa-hcp-mc-e2e-promotion-int N/A periodic Registry content changed
periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-staging-stable-4-22 N/A periodic Registry content changed
periodic-ci-openshift-online-rosa-e2e-main-upgrade-rosa-hcp-upgrade-staging-y-minus-1 N/A periodic Registry content changed
periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-20 N/A periodic Periodic changed
periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-fips-e2e-staging-nightly-5-0 N/A periodic Registry content changed
periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-staging-stable-4-19 N/A periodic Registry content changed
periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-candidate-5-0 N/A periodic Periodic changed
periodic-ci-openshift-route-monitor-operator-master-rosa-hcp-mc-e2e-promotion-stage N/A periodic Registry content changed
periodic-ci-openshift-online-rosa-e2e-main-upgrade-rosa-hcp-upgrade-staging-y-minus-2 N/A periodic Registry content changed
periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-fips-e2e-staging-stable-4-19 N/A periodic Registry content changed
periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-fips-e2e-staging-stable-4-21 N/A periodic Registry content changed
periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-staging-candidate-5-0 N/A periodic Periodic changed
periodic-ci-openshift-aws-vpce-operator-main-rosa-hcp-mc-e2e-promotion-stage N/A periodic Registry content changed
periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-fips-e2e-staging-stable-4-20 N/A periodic Registry content changed
periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-staging-stable-4-21 N/A periodic Registry content changed
periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-22 N/A periodic Periodic changed
periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-21 N/A periodic Periodic changed
periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-fips-e2e-staging-stable-4-22 N/A periodic Registry content changed
periodic-ci-openshift-aws-vpce-operator-main-rosa-hcp-mc-e2e-promotion-int N/A periodic Registry content changed
periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-staging-stable-4-20 N/A periodic Registry content changed
periodic-ci-openshift-online-rosa-e2e-main-upgrade-rosa-hcp-upgrade-staging-y-minus-3 N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dustman9000

Copy link
Copy Markdown
Member

/lgtm
/approve
/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 26, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2026
@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, dustman9000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 33616af into openshift:main Aug 26, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants