[ROSAENG-61879] adding rosa-e2e int testing - #84059
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe periodic configuration changes staging HCP 5.0 to the candidate channel, adds integration-environment HCP jobs for OpenShift 4.20–4.22 and candidate 5.0, and normalizes integration namespace names. ChangesROSA HCP periodic coverage
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR adds ROSA end-to-end integration testing and related CI updates; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.) Full details: Stable And Deterministic Test NamesExplanation The custom check "Stable and Deterministic Test Names" requires flagging Ginkgo test names (It(), Describe(), Context(), When(), etc.) that contain dynamic information such as generated identifiers, timestamps, pod names with suffixes, or other runtime-specific values. The check does not apply to this PR because no Ginkgo test code is modified. The PR contains only CI/CD configuration changes (two YAML files with periodic job definitions) and a shell script modification for namespace construction in a deployment script. No test title declarations are introduced, modified, or removed. Full details: Test Structure And QualityExplanation PASS: The pull request changes only periodic YAML configuration, generated Prow jobs, and a shell namespace mapping. The diff contains no Ginkgo test code, It blocks, resource fixtures, or Eventually/Consistently calls. Therefore, the listed Ginkgo test-structure requirements are not applicable to the changed code. Full details: Microshift Test CompatibilityExplanation The custom check for MicroShift Test Compatibility applies to "When new Ginkgo e2e tests are added (It(), Describe(), Context(), When(), etc.)". This PR does not add any Ginkgo e2e test code. The PR contains only CI configuration changes (20 YAML files, 3 shell scripts) and modifies OpenShift CI workflow definitions for ROSA E2E testing. No Go test files or Ginkgo test definitions are introduced. The actual ROSA E2E tests come from a separate base image built from the Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The pull request adds periodic ROSA job configuration and namespace normalization only. The complete diff changes two YAML files and one shell script; it adds no Ginkgo test declarations or Go/test files. Therefore, the SNO multi-node compatibility check is not applicable. Full details: Topology-Aware Scheduling CompatibilityExplanation The check is not triggered by this pull request. The diff adds periodic CI configuration and generated ProwJob objects, plus namespace normalization in a readiness shell script. The added job specs introduce no node selectors, affinity or anti-affinity, topology spread constraints, tolerations, PDBs, or deployment replica strategies. The shell change only maps Full details: Ote Binary Stdout ContractExplanation PASS. The pull request changes only two YAML job/configuration files and one ROSA shell step. The added code creates integration job definitions and normalizes the namespace token from Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation The custom check "IPv6 and Disconnected Network Test Compatibility" specifies that it applies "when new Ginkgo e2e tests are added (It(), Describe(), Context(), When(), etc.)". Investigation confirms that this pull request does NOT add any new Ginkgo e2e tests. The three modified files are: 1. Full details: No-Weak-CryptoExplanation The custom check "no-weak-crypto" requires flagging MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB mode usage; custom crypto implementations; and non-constant-time secret comparisons. Investigation findings: 1. Modified Files: The pull request changes two files: - Full details: Container-PrivilegesExplanation The pull request adds CI configuration for new ROSA E2E integration tests and updates a shell script for namespace handling. The changes do not introduce any container privilege escalation settings. Container specifications in the generated ProwJob manifests use standard, non-privileged configurations with no Full details: No-Sensitive-Data-In-LogsExplanation The pull request adds ROSA E2E integration tests and modifies a shell script to normalize the OCM environment token in namespace names. The custom check requires detection of logging that exposes passwords, tokens, API keys, PII (email, SSN, credit card), session IDs, internal hostnames, or customer data. Investigation findings: 1. YAML configuration changes: The PR adds four new periodic job definitions for integration-environment HCP tests (stable 4.20, 4.21, 4.22, and candidate 5.0) and changes one staging job's channel from nightly to candidate. These configuration files contain only non-sensitive environment variables: CHANNEL_GROUP, CLUSTER_SECTOR, ENABLE_BILLING_ACCOUNT, HOSTED_CP, LABEL_FILTER, OCM_LOGIN_ENV (set to "integration"), OPENSHIFT_VERSION, REGION, and REPLICAS. 2. Shell script changes: The PR modifies ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-periodics-integration-rosa-hcp-e2e-integration-nightly-5-0 |
|
@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-22 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-candidate-5-0 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-21 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-20 |
|
@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-22 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-candidate-5-0 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-21 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-20 |
|
@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-22 |
|
@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-22 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-candidate-5-0 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-21 periodic-ci-openshift-online-rosa-e2e-main-periodics-rosa-hcp-e2e-integration-stable-4-20 |
|
@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bmeng, dustman9000 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
adding one integration rosa-e2e testing
Summary by CodeRabbit
openshift-online/rosa-e2erepository.integrationlogin environment tointwhen constructing ROSA HCP namespaces.main.