[Debug] Add wait step to baremetalds-two-node-arbiter-upgrade for OCP 4.20 - #84057
Conversation
… 4.20 This adds a wait step to enable debugging of test failures in OCP 4.20. The wait step pauses the workflow before tests run, allowing QE to: - SSH into the test environment - Inspect system state and logs - Debug configuration issues - Investigate test failures OCP Version: 4.20 Workflow: baremetalds-two-node-arbiter-upgrade Timeout: 24h
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review. WalkthroughThe changes add a best-effort 24-hour wait before bare-metal IPI tests and update Cluster Observability Operator defaults for dashboard and incident UI tests. ChangesBare-metal upgrade workflow
Monitoring plugin test defaults
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR adds a temporary 24-hour debugging pause to one workflow and is explicitly marked for closure after debugging; no actionable merge-blocking risk is identified in the supplied evidence. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.) Full details: Stable And Deterministic Test NamesExplanation PASS: The pull request changes only workflow/configuration YAML. The added Full details: Test Structure And QualityExplanation PASS: The pull request changes only three CI YAML files. The diff adds a 24-hour Full details: Microshift Test CompatibilityExplanation PASS: The pull request changes only three YAML files. The diff from origin/main contains no Go files and adds no Ginkgo tests ( Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The PR changes only three YAML files. The diff adds a 24-hour wait step and changes Cypress environment defaults. It adds no Go files, Ginkgo declarations, or new tests. The existing Full details: Topology-Aware Scheduling CompatibilityExplanation PASS: The pull request changes only CI workflow and test-step reference YAML. It adds a generic 24-hour Full details: Ote Binary Stdout ContractExplanation PASS — The pull request changes only three YAML files. It adds a shell-based Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS: The pull request adds no Ginkgo tests. The diff changes only three YAML files, adds a wait step, and updates Cypress step defaults. The existing Full details: No-Weak-CryptoExplanation PASS. The PR adds a wait step and changes two environment defaults. The only digest is SHA-256, not SHA-1. The added lines contain no MD5, SHA-1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret/token comparisons. The referenced wait implementation only sleeps and checks a file. Full details: Container-PrivilegesExplanation PASS. The pull request adds the existing Full details: No-Sensitive-Data-In-LogsExplanation PASS. The PR adds only a 24-hour ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: etmurasaki The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
A total of 42 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/test periodic-ci-openshift-release-main-nightly-4.21-e2e-metal-ovn-two-node-arbiter-upgrade |
|
@etmurasaki: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test periodic-ci-openshift-release-main-nightly-4.20-e2e-metal-ovn-two-node-arbiter-upgrade |
|
@etmurasaki: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.20-e2e-metal-ovn-two-node-arbiter-upgrade |
|
@etmurasaki: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.20-e2e-metal-ovn-two-node-arbiter-upgrade |
|
@etmurasaki: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-arbiter-upgrade |
|
@etmurasaki: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 participant
Summary
The wait step pauses the workflow before tests run, allowing QE to:
Summary by CodeRabbit
baremetalds-two-node-arbiter-upgradeworkflow. This gives QE time to inspect the environment, logs, configuration, and test failures.