chore: specify Go1.26 consistently - #84047
Conversation
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
openshift-ci
Bot
added
the
approved
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (32)
💤 Files with no reviewable changes (14)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe PR updates Stolostron CI build configurations to use Go 1.26 builder tags and removes explicit Go 1.25 builder image inputs from selected release builds. ChangesStolostron builder configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR standardizes Go 1.26 references across configuration files without any identified merge-blocking risk; it is merge-ready after normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (18 skipped: 18 unsupported.) Full details: Stable And Deterministic Test NamesExplanation PASS: The pull request changes only 32 CI YAML files. The diff updates Go image tags and removes builder image mappings. It adds no Ginkgo test declarations or test titles, and it introduces no dynamic test-name values. Full details: Test Structure And QualityExplanation PASS — The pull request changes only 32 CI YAML files. The diff updates Go builder image tags and removes builder-image mappings. It changes no Ginkgo test files or test code, and the changed files contain no Ginkgo lifecycle, wait, or assertion constructs. Therefore this test-quality check is not applicable. Full details: Microshift Test CompatibilityExplanation PASS: The pull request changes only 32 CI YAML files. The diff updates Go builder image tags and removes builder-image mappings. It adds no Ginkgo tests, test declarations, MicroShift-sensitive API references, namespaces, or unsupported feature assumptions. The MicroShift Test Compatibility check is therefore not applicable. Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The pull request changes only 32 YAML files under Full details: Topology-Aware Scheduling CompatibilityExplanation PASS: The commit changes only Full details: Ote Binary Stdout ContractExplanation PASS. The pull request changes only 32 CI YAML files. The diff only removes Go 1.25 builder image mappings or changes Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS: The pull request adds no Ginkgo e2e tests. The exact commit diff changes only 32 ci-operator YAML files by updating Go builder tags or removing builder image mappings. No test declarations, IPv4 assumptions, or external connectivity requirements were introduced. Full details: No-Weak-CryptoExplanation PASS. The commit changes only 32 YAML CI configuration files. Added lines only change builder tags to Full details: Container-PrivilegesExplanation PASS: The pull request changes only 32 CI configuration YAML files. The added lines are limited to Full details: No-Sensitive-Data-In-LogsExplanation No sensitive-data logging was introduced. The verified PR diff changes only YAML image configuration: 18 additions, all ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse skip |
|
@dhaiducek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
@dhaiducek: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cc @JustinKuli @jan-law |
2 participants
Summary by CodeRabbit
go1.26-linuxacross ACM, Backplane, and must-gather configurations.stolostron_builder_go1.25-linuxdefinitions and input mappings from component image builds.