Skip to content

enable hibernation for 4.18-4.22 rhoe cluster pools - #84045

Open
acornett21 wants to merge 1 commit into
openshift:mainfrom
acornett21:rhoe_hibernation
Open

enable hibernation for 4.18-4.22 rhoe cluster pools#84045
acornett21 wants to merge 1 commit into
openshift:mainfrom
acornett21:rhoe_hibernation

Conversation

@acornett21

@acornett21 acornett21 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Removes runningCount from the rhoe-owned SNO cluster pools (4.18, 4.19, 4.20, 4.21, 4.22) so clusters hibernate when unclaimed instead of running 24/7. Real claim-usage data (Prow/GCS job history) shows these pools sit idle 82–99%+ of the time depending on version, and observed hibernation resume times are typically ~3 minutes (worst case observed: a fresh reinstall of 35–55 min if resume exceeds the 20m resumeTimeout, still within the 1h claim timeout). Estimated savings: ~$3,642/month in EC2 compute.

Summary by CodeRabbit

  • Enables hibernation for RHOE-owned SNO cluster pools running OpenShift 4.18 through 4.22.
  • Removes runningCount from six ClusterPool manifests while preserving each pool's configured size.
  • Allows unclaimed clusters to hibernate instead of running continuously.
  • Supports estimated monthly EC2 compute savings of approximately $3,642 based on observed pool idle time.

Signed-off-by: Adam D. Cornett <adc@redhat.com>
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 25, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@acornett21: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci
openshift-ci Bot requested review from deepsm007 and pruan-rht August 25, 2026 20:23
@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2026
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: f5c9f60d-f1a0-4ba9-ab72-9bebe3928741

📥 Commits

Reviewing files that changed from the base of the PR and between 40e3c47 and 502ff09.

📒 Files selected for processing (6)
  • clusters/hosted-mgmt/hive/pools/rh-openshift-ecosystem/sno/rhoe-ocp-4-18-sno-amd64-aws-us-east-1_clusterpool.yaml
  • clusters/hosted-mgmt/hive/pools/rh-openshift-ecosystem/sno/rhoe-ocp-4-19-sno-amd64-aws-us-east-1_clusterpool.yaml
  • clusters/hosted-mgmt/hive/pools/rh-openshift-ecosystem/sno/rhoe-ocp-4-20-sno-amd64-aws-us-west-2_clusterpool.yaml
  • clusters/hosted-mgmt/hive/pools/rh-openshift-ecosystem/sno/rhoe-ocp-4-21-sno-amd64-aws-us-east-2_clusterpool.yaml
  • clusters/hosted-mgmt/hive/pools/rh-openshift-ecosystem/sno/rhoe-ocp-4-22-sno-amd64-aws-us-west-1_clusterpool.yaml
  • clusters/hosted-mgmt/hive/pools/rh-openshift-ecosystem/sno/rhoe-ocp-4-22-sno-amd64-aws-us-west-2_clusterpool.yaml
💤 Files with no reviewable changes (6)
  • clusters/hosted-mgmt/hive/pools/rh-openshift-ecosystem/sno/rhoe-ocp-4-20-sno-amd64-aws-us-west-2_clusterpool.yaml
  • clusters/hosted-mgmt/hive/pools/rh-openshift-ecosystem/sno/rhoe-ocp-4-18-sno-amd64-aws-us-east-1_clusterpool.yaml
  • clusters/hosted-mgmt/hive/pools/rh-openshift-ecosystem/sno/rhoe-ocp-4-21-sno-amd64-aws-us-east-2_clusterpool.yaml
  • clusters/hosted-mgmt/hive/pools/rh-openshift-ecosystem/sno/rhoe-ocp-4-19-sno-amd64-aws-us-east-1_clusterpool.yaml
  • clusters/hosted-mgmt/hive/pools/rh-openshift-ecosystem/sno/rhoe-ocp-4-22-sno-amd64-aws-us-west-1_clusterpool.yaml
  • clusters/hosted-mgmt/hive/pools/rh-openshift-ecosystem/sno/rhoe-ocp-4-22-sno-amd64-aws-us-west-2_clusterpool.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The changes remove runningCount from six SNO ClusterPool manifests. Each pool retains its existing size setting.

Changes

ClusterPool sizing configuration

Layer / File(s) Summary
Remove running-count settings
clusters/hosted-mgmt/hive/pools/rh-openshift-ecosystem/sno/rhoe-ocp-4-19-sno-amd64-aws-us-east-1_clusterpool.yaml, clusters/hosted-mgmt/hive/pools/rh-openshift-ecosystem/sno/rhoe-ocp-4-20-sno-amd64-aws-us-west-2_clusterpool.yaml, clusters/hosted-mgmt/hive/pools/rh-openshift-ecosystem/sno/rhoe-ocp-4-21-sno-amd64-aws-us-east-2_clusterpool.yaml, clusters/hosted-mgmt/hive/pools/rh-openshift-ecosystem/sno/rhoe-ocp-4-22-sno-amd64-aws-us-west-1_clusterpool.yaml, clusters/hosted-mgmt/hive/pools/rh-openshift-ecosystem/sno/rhoe-ocp-4-22-sno-amd64-aws-us-west-2_clusterpool.yaml
The manifests remove runningCount and retain size: 1 or size: 3 for pool sizing.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 502ff

The change allows the specified idle cluster pools to hibernate instead of running continuously; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: enabling hibernation for the RHOE cluster pools running versions 4.18 through 4.22.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The pull request changes only six ClusterPool YAML files. The diff removes runningCount settings and adds no Ginkgo test declarations or test titles. Therefore, it introduces no unstable or ov…
Test Structure And Quality ✅ Passed PASS: The pull request changes only six ClusterPool YAML manifests. The exact diff removes runningCount entries and contains no Ginkgo tests or test-related code. Therefore, the listed test structur…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only six ClusterPool YAML files. The diff removes existing runningCount fields and adds no Ginkgo tests or test code. Therefore, the MicroShift test compatibility chec…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only six ClusterPool YAML manifests. The diff removes runningCount and retains size; it adds no Ginkgo tests or test code. Therefore, the SNO multi-node test compati…
Topology-Aware Scheduling Compatibility ✅ Passed PASS — The pull request changes only six ClusterPool YAML files and deletes one runningCount field from each. The diff adds no affinity, topology spread, node selector or affinity, toleration, r…
Ote Binary Stdout Contract ✅ Passed PASS: The pull request changes only six ClusterPool YAML files. The exact diff removes runningCount entries and does not add or modify Go code, main, suite setup, logging, or any stdout write. The…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS — The pull request changes only six ClusterPool YAML files. The verified HEAD^..HEAD diff removes runningCount entries and adds no Ginkgo or e2e tests. Therefore, the IPv6 and disconnected netw…
No-Weak-Crypto ✅ Passed PASS: The complete pull-request commit changes only six ClusterPool YAML files and removes six runningCount lines. It adds no lines and introduces no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypt…
Container-Privileges ✅ Passed PASS. The pull request changes only six ClusterPool YAML files and deletes runningCount entries. The exact diff has no added privilege-related settings. The current changed manifests contain no `pri…
No-Sensitive-Data-In-Logs ✅ Passed PASS: The commit changes only six ClusterPool YAML files. Each change deletes one runningCount field and adds no lines. No logging configuration, log statements, credentials, tokens, passwords, PII,…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Full details: Stable And Deterministic Test Names

Explanation

PASS. The pull request changes only six ClusterPool YAML files. The diff removes runningCount settings and adds no Ginkgo test declarations or test titles. Therefore, it introduces no unstable or overly specific test names.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only six ClusterPool YAML manifests. The exact diff removes runningCount entries and contains no Ginkgo tests or test-related code. Therefore, the listed test structure and quality requirements are not applicable.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request changes only six ClusterPool YAML files. The diff removes existing runningCount fields and adds no Ginkgo tests or test code. Therefore, the MicroShift test compatibility check is not applicable, and no stated failure condition is introduced.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request changes only six ClusterPool YAML manifests. The diff removes runningCount and retains size; it adds no Ginkgo tests or test code. Therefore, the SNO multi-node test compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS — The pull request changes only six ClusterPool YAML files and deletes one runningCount field from each. The diff adds no affinity, topology spread, node selector or affinity, toleration, replica, rollout, or PDB constraint. size is the ClusterPool size, not a workload replica count. No operator or controller code changed, and the existing hibernationConfig is unchanged. Therefore, the pull request introduces no topology-incompatible scheduling constraint.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The pull request changes only six ClusterPool YAML files. The exact diff removes runningCount entries and does not add or modify Go code, main, suite setup, logging, or any stdout write. Therefore, it introduces no OTE binary stdout contract violation.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS — The pull request changes only six ClusterPool YAML files. The verified HEAD^..HEAD diff removes runningCount entries and adds no Ginkgo or e2e tests. Therefore, the IPv6 and disconnected network test compatibility check is not applicable.

Full details: No-Weak-Crypto

Explanation

PASS: The complete pull-request commit changes only six ClusterPool YAML files and removes six runningCount lines. It adds no lines and introduces no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret/token comparison logic. The remaining hibernationConfig and resumeTimeout fields are unrelated to cryptography.

Full details: Container-Privileges

Explanation

PASS. The pull request changes only six ClusterPool YAML files and deletes runningCount entries. The exact diff has no added privilege-related settings. The current changed manifests contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root security-context declarations.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The commit changes only six ClusterPool YAML files. Each change deletes one runningCount field and adds no lines. No logging configuration, log statements, credentials, tokens, passwords, PII, hostnames, or customer data were introduced.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@acornett21: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant