Skip to content

Add owners to osac-cicd#80811

Open
rgolangh wants to merge 1 commit into
openshift:mainfrom
rgolangh:rgo
Open

Add owners to osac-cicd#80811
rgolangh wants to merge 1 commit into
openshift:mainfrom
rgolangh:rgo

Conversation

@rgolangh

@rgolangh rgolangh commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Signed-off-by: Roy Golan rgolan@redhat.com

Summary by CodeRabbit

This PR extends the ownership of the osac-cicd CI configuration by adding two new owners to the osac-cicd alias in OWNERS_ALIASES: rgolangh and masayag. These additions expand the set of maintainers responsible for the OpenStack Assisted service CI/CD infrastructure, joining the existing owners: adriengentil, jhernand, akshaynadkarni, larsks, and trewest.

The change affects ownership and review responsibilities for the OpenShift CI infrastructure configuration used to manage the Assisted service's continuous integration pipelines.

Signed-off-by: Roy Golan <rgolan@redhat.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rgolangh: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 21, 2026
@openshift-ci openshift-ci Bot requested review from bear-redhat and jmguzik June 21, 2026 12:51
@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9b4b8f23-60a3-47df-841a-d35174039e75

📥 Commits

Reviewing files that changed from the base of the PR and between 224511a and e1707b4.

📒 Files selected for processing (1)
  • OWNERS_ALIASES

Walkthrough

Two usernames, rgolangh and masayag, are appended to the osac-cicd alias list in OWNERS_ALIASES.

Changes

OWNERS_ALIASES Update

Layer / File(s) Summary
Add members to osac-cicd alias
OWNERS_ALIASES
Appends rgolangh and masayag to the osac-cicd alias list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add owners to osac-cicd' directly and clearly describes the main change: adding two usernames to the osac-cicd alias list in the OWNERS_ALIASES file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only OWNERS_ALIASES configuration file, adding owners to osac-cicd. No Ginkgo test files were modified, and the repository contains no Ginkgo tests. The check is not applicable.
Test Structure And Quality ✅ Passed PR modifies only OWNERS_ALIASES file; no Ginkgo test code changes present, so the check is not applicable.
Microshift Test Compatibility ✅ Passed PR adds no Ginkgo e2e tests; only config changes and standard Go unit tests are added, so MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only modifies OWNERS_ALIASES to add usernames to the osac-cicd alias. No Ginkgo e2e tests are being added, so the SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed This PR only modifies OWNERS_ALIASES to add two usernames (rgolangh, masayag) to the osac-cicd ownership alias. The check applies to "deployment manifests, operator code, or controllers"—none of wh...
Ote Binary Stdout Contract ✅ Passed PR only updates OWNERS_ALIASES configuration file; no stdout-related code changes or test binary modifications present.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo e2e tests are added in this PR. The PR only updates OWNERS_ALIASES to add usernames to the osac-cicd alias, plus includes some utility Go code without Ginkgo patterns. Check is not applic...
No-Weak-Crypto ✅ Passed PR only modifies OWNERS_ALIASES, a YAML configuration file listing user aliases. No cryptographic algorithms, custom crypto implementations, or security-sensitive code present.
Container-Privileges ✅ Passed PR only modifies OWNERS_ALIASES file to add usernames to osac-cicd alias; no container or K8s manifests with privileged configs are changed.
No-Sensitive-Data-In-Logs ✅ Passed The PR only adds two public GitHub usernames (rgolangh and masayag) to the OWNERS_ALIASES file. No passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data are expose...

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@omer-vishlitzky

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2026
@openshift-ci

openshift-ci Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omer-vishlitzky, rgolangh
Once this PR has been reviewed and has the lgtm label, please assign smg247 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

@rgolangh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants