OSAC-1629: skip prow ci for non-code config and metadata changes#80782
OSAC-1629: skip prow ci for non-code config and metadata changes#80782amej wants to merge 1 commit into
Conversation
|
@amej: This pull request references OSAC-1629 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
WalkthroughFour osac-project CI operator configurations have their ChangesCI skip pattern updates across osac-project
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @adriengentil and @akshaynadkarni : Please can you review the #80782 ? |
|
/pj-rehearse auto-ack |
|
@amej: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-osac-project-osac-test-infra-main-e2e-vmaas |
|
@amej: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, akshaynadkarni, amej The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/pj-rehearse pull-ci-osac-project-osac-test-infra-main-e2e-vmaas |
|
@amej: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Expands skip_if_only_changed patterns to skip CI when PRs only modify configuration, documentation, IDE settings, and other non-code files that don't affect runtime behavior or tests. Changes by repository: fulfillment-service (unit + e2e-vmaas): - Added IDE/config: .ai-bot/, .claude/, .vscode/, .idea/ - Added lint/format: .pre-commit-config.*, .yamllint.yaml, .golangci.yml - Added build/package: .copr/, .goreleaser.yaml, buf.* - Added git/docker: .dockerignore, .gitattributes, .gitignore, .gitleaks.toml - Added python: pyproject.toml, .python-version, uv.lock - Added metadata: docs/, CLAUDE.md, AGENTS.md, OWNERS - Expanded: .github/workflows/ → .github/ - Updated: unit job now has same skip patterns as e2e-vmaas job osac-operator (e2e-vmaas): - Expanded: .claude/rules/.* → .claude/.* - Added IDE: .vscode/, .idea/ - Added build: buf.* - Added git: .gitignore - Already had: .dockerignore, .gitattributes osac-aap (e2e-vmaas): - Added config: .claude/, .pre-commit-config.*, .yamllint.yaml - Added git/python: .gitignore, pyproject.toml, .python-version, uv.lock - Expanded: .github/workflows/.* → .github/.* osac-test-infra (e2e-vmaas): - Expanded: .claude/rules/.* → .claude/.* - Added lint: .ansible-lint - Added git/python: .gitignore, pyproject.toml, uv.lock - Already had: .dockerignore, .gitattributes All patterns verified to exist and be git-tracked in target repositories. Rationale: These files contain configuration, documentation, IDE settings, build tooling config, and dependency metadata with no runtime code impact. Skipping CI for these changes reduces unnecessary load while maintaining test coverage for actual code changes. Note: fulfillment-service unit job previously only skipped charts/, it/, and basic docs - now matches e2e-vmaas comprehensiveness for consistency. Expected impact: ~25-30% reduction in unnecessary CI runs for config-only and documentation-only PRs. Assisted-by: Claude Code <noreply@anthropic.com> Signed-off-by: Ameya Sathe <asathe@redhat.com> rh-pre-commit.version: 2.4.0 rh-pre-commit.check-secrets: ENABLED
|
New changes are detected. LGTM label has been removed. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@amej: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Updated: Extended ScopeI've force-pushed an updated commit that expands the scope beyond just What ChangedBefore: Only New Patterns AddedAll patterns verified to be git-tracked and have zero runtime impact:
Impact
RationaleBased on Rom Freiman's analysis, this comprehensive approach:
All patterns were individually verified against git-tracked files in each repo. Nothing was added speculatively. Special note: fulfillment-service See the full Jira comment for detailed breakdown: https://redhat.atlassian.net/browse/OSAC-1629 |
amej
left a comment
There was a problem hiding this comment.
As the author of ther PR; I have reviewed the changes.
|
/pj-rehearse |
|
@amej: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/assign @adriengentil |
|
/pj-rehearse ack |
|
@amej: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Summary
Expands
skip_if_only_changedpatterns across OSAC repositories to skip CI when PRs only modify configuration, documentation, IDE settings, and other non-code files with no runtime impact.Jira: OSAC-1629
Changes
Repositories Updated
osac-project/fulfillment-service(unit + e2e-vmaas jobs)osac-project/osac-operator(e2e-vmaas job)osac-project/osac-aap(e2e-vmaas job)osac-project/osac-test-infra(e2e-vmaas job)Pattern Categories Added
IDE & AI Config:
^docs/- Documentation directory^\\.ai-bot/- AI bot configuration^\\.claude/- Claude Code configuration (expanded.claude/rules/.*→.claude/.*)^\\.vscode/- VS Code settings^\\.idea/- IntelliJ IDEA settingsLint & Format Config:
^\\.pre-commit-config.*- Pre-commit hooks^\\.yamllint\\.yaml$- YAML linting^\\.golangci\\.yml$- Go linting (runs in GH Actions)^\\.ansible-lint- Ansible lintingBuild & Package Config:
^\\.copr/- COPR packaging^\\.goreleaser\\.yaml$- Release automation^buf\\.- Protobuf codegen (buf.gen.yaml, buf.lock, buf.yaml)Git & Docker Config:
^\\.dockerignore$- Docker build exclusions^\\.gitattributes$- Git line-ending config^\\.gitignore$- Git exclusions^\\.gitleaks\\.toml$- Secret scanning configPython Metadata:
^pyproject\\.toml$- Python project metadata^\\.python-version$- Python version pinning^uv\\.lock$- Python dependency lockMetadata Files:
^CLAUDE\\.md$,^AGENTS\\.md$- AI assistant instructions^OWNERS$- GitHub/Prow review routing^\\.github/- Expanded from.github/workflows/→.github/Special Updates
fulfillment-service unit job: Previously only skipped
charts/,it/, and basic docs. Updated to match e2e-vmaas comprehensiveness (5 patterns → 20 patterns).Verification
All patterns verified to:
Validation:
Impact
.github/only): ~10-15% reductionRepository-Specific Changes
fulfillment-service (unit + e2e-vmaas):
osac-operator (e2e-vmaas):
osac-aap (e2e-vmaas):
osac-test-infra (e2e-vmaas):
Rationale
Files Changed
Pattern recommendations from Rom Freiman's analysis