Use /dev/disk/by-id/coreos-boot-disk when creating /var partition

[jlebon]

This has been supported for a while and simplifies things because then your Ignition config is no longer specific to a device name.

Version(s):

It's quite old, but we can just do 4.19+.

Issue:

No direct issue. Came up while I was looking at https://issues.redhat.com/browse/OCPBUGS-62461.

Link to docs preview:

QE review:

• QE has approved this change.

Additional information:

[ocpdocs-previewbot]

🤖 Tue Apr 21 19:26:29 - Prow CI generated the docs preview:
https://99875--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[jlebon]

This is still relevant.

/remove-lifecycle rotten

[jlebon]

cc @jldohmann

[jldohmann]

@jlebon we have updated guidance for callouts as we prepare for migrating to DITA, so i've added some things to show what that looks like. overall LGTM 😄

[jlebon]

Thanks for the review! Updated!

[jldohmann]

cc: @mburke5678 😄 it LGTM, but now that i'm on the ROSA team i think it would benefit from another pair of eyes

[mburke5678]

@jlebon Can you please squash the commits?

[jlebon]

Done!

[openshift-ci]

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.