Add DNS resolver and routes to node addition YAML example - #119181
Open
msarage-ux wants to merge 1 commit into
Open
Add DNS resolver and routes to node addition YAML example#119181msarage-ux wants to merge 1 commit into
msarage-ux wants to merge 1 commit into
Conversation
Update the nodes-config.yaml example to include DNS resolver and routes configuration, which are required for successful node addition. Also document that CSRs must be approved twice during the node addition process. Changes: - Added dns-resolver section with server and search configuration - Added routes section with default gateway configuration - Added IMPORTANT note about double CSR approval requirement - Clarified that first CSR is for kubelet client certificate - Clarified that second CSR is for kubelet serving certificate The missing DNS configuration was causing node join failures. These additions ensure users have a complete working example. Fixes: OSDOCS-15544 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Hi @msarage-ux. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the incomplete
nodes-config.yamlexample in the node addition guide by adding required DNS resolver and routes configuration, and documents the double CSR approval requirement.Issue
Fixes: OSDOCS-15544
Problem
The current
nodes-config.yamlexample in the OCP 4.17 node addition guide is missing critical network configuration:dns-resolversection with DNS server and search domainThese omissions caused node join failures in production environments. Users following the documentation example would create incomplete network configurations.
Solution
Updated the example YAML configuration to include:
DNS Resolver Configuration
Routes Configuration
CSR Approval Documentation
Added an IMPORTANT note explaining:
Changes
dns-resolversection to both worker examplesroutessection to both worker examplesImpact
Testing
References
🤖 Generated with Claude Code