OSDOCS-16945# CQA work Stor1-- non-graceful shutdown#106592
Open
lpettyjo wants to merge 1 commit into
Open
Conversation
openshift-ci
Bot
added
the
size/M
lpettyjo
added
merge-review-needed
|
🤖 Fri Feb 13 19:05:47 - Prow CI generated the docs preview: |
|
@lpettyjo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-ci
Bot
added
the
size/M
mburke5678
added
the
merge-review-in-progress
mburke5678
reviewed
Feb 16, 2026
| ---- | ||
| <1> <node_name> = name of the node that shut down non-gracefully | ||
| + | ||
| * `<node_name>` = name of the node that shut down non-gracefully |
Contributor
There was a problem hiding this comment.
Per the SSG: Use a simple sentence to explain or describe a single line of command, variable, option, or parameter.
Suggested change
| * `<node_name>` = name of the node that shut down non-gracefully | |
| Use the `<node_name>` to specify the node that shut down non-gracefully. |
mburke5678
reviewed
Feb 16, 2026
| <1> <node_name> = name of the node that shut down non-gracefully | ||
| + | ||
| After the taint is applied, the volumes detach from the shutdown node allowing their disks to be attached to a different node. | ||
| * `<node_name>` = name of the node that shut down non-gracefully |
Contributor
There was a problem hiding this comment.
Suggested change
| * `<node_name>` = name of the node that shut down non-gracefully | |
| Use the `<node_name>` to specify the node that shut down non-gracefully. |
mburke5678
reviewed
Feb 16, 2026
| ---- | ||
| <1> <node_name> = name of the node that shut down non-gracefully | ||
| + | ||
| * `<node_name>` = name of the node that shut down non-gracefully |
Contributor
There was a problem hiding this comment.
Suggested change
| * `<node_name>` = name of the node that shut down non-gracefully | |
| Use the `<node_name>` to specify the node that shut down non-gracefully. |
Contributor
|
@lpettyjo A couple of nits. Otherwise LGTM. |
lpettyjo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version(s): 4.16+
Issue: https://issues.redhat.com/browse/OSDOCS-16945
Link to docs preview: https://106592--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/persistent-storage-csi-vol-detach-non-graceful-shutdown.html
QE review:
Additional information: