Skip to content

OSDOCS-13351#Vol group snapshots TP -> GA - #101795

Open
lpettyjo wants to merge 1 commit into
openshift:mainfrom
lpettyjo:OSDOCS-13351
Open

OSDOCS-13351#Vol group snapshots TP -> GA#101795
lpettyjo wants to merge 1 commit into
openshift:mainfrom
lpettyjo:OSDOCS-13351

Conversation

@lpettyjo

@lpettyjo lpettyjo commented Nov 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 5, 2025
@lpettyjo lpettyjo added this to the Planned for 4.21 GA milestone Nov 5, 2025
@lpettyjo
lpettyjo requested a review from gnufied November 5, 2025 16:20
@ocpdocs-previewbot

ocpdocs-previewbot commented Nov 5, 2025 •
edited
Loading

Copy link
Copy Markdown

🤖 Tue Sep 01 15:22:17 - Prow CI generated the docs preview:

https://101795--ocpdocs-pr.netlify.app/openshift-dedicated/latest/storage/container_storage_interface/persistent-storage-csi.html
https://101795--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-group-snapshots.html
https://101795--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi.html
https://101795--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/container_storage_interface/persistent-storage-csi.html
https://101795--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/container_storage_interface/persistent-storage-csi.html

@duanwei33

duanwei33 commented Jan 15, 2026

Copy link
Copy Markdown

@lpettyjo The volumegroupsnapshot is still TP in 4.21, we just bump API to v1beta2.

@duanwei33 duanwei33 mentioned this pull request Jan 15, 2026
Merged
1 task
@lpettyjo

lpettyjo commented Jan 16, 2026

Copy link
Copy Markdown
Contributor Author

Yup. My bad. Here's the correct PR for the API bump: #104901.

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 5, 2026
@lpettyjo lpettyjo closed this Jul 17, 2026
@lpettyjo lpettyjo reopened this Aug 17, 2026
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 17, 2026
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 17, 2026
@lpettyjo lpettyjo added branch/enterprise-5.0 and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 17, 2026
@openshift openshift deleted a comment from openshift-bot Aug 18, 2026
@openshift-ci openshift-ci Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 1, 2026
@openshift-ci openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 1, 2026
@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown

@lpettyjo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

dobsonj
dobsonj reviewed Sep 16, 2026
View reviewed changes
Comment thread modules/persistent-storage-csi-group-snapshots-overview.adoc
Created by cluster administrators to describe how volume group snapshots should be created, including the driver information, the deletion policy, etc.

These three API kinds are defined as `CustomResourceDefinitions` (CRDs). These CRDs must be installed in a {product-title} cluster for a CSI driver to support volume group snapshots. No newline at end of file
These three API kinds are defined as `CustomResourceDefinitions` (CRDs). These CRDs must be installed in a {product-title} cluster for a CSI driver to support volume group snapshots.

@dobsonj dobsonj Sep 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mention that these CRDs are installed by default now since the feature is GA? Without that detail, one might wonder how to install them.

@gcharot gcharot Sep 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes +1 the way it's written now may let customers think they have to install them

Comment thread modules/persistent-storage-csi-group-snapshot-create-admin.adoc

.Prerequisites
* Logged in to a running {product-title} cluster with administrator privileges.
* Enabled this feature using feature gates. For information about how to use feature gates, see "Enabling features sets by using feature gates".

@dobsonj dobsonj Sep 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove the Enabled this feature using feature gates line now that the feature is GA and enabled by default.

@gcharot gcharot Sep 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment thread modules/persistent-storage-csi-group-snapshots-create.adoc

.Prerequisites
* Logged in to a running {product-title} cluster.
* Enabled this feature using feature gates. For information about how to use feature gates, see "Enabling features sets by using feature gates".

@dobsonj dobsonj Sep 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove the Enabled this feature using feature gates line now that the feature is GA and enabled by default.

@gcharot gcharot Sep 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

gcharot
gcharot reviewed Sep 17, 2026
View reviewed changes
Comment thread modules/persistent-storage-csi-group-snapshots-overview.adoc
@@ -9,11 +9,6 @@
[role="_abstract"]
Volume group snapshots capture point-in-time copies of multiple persistent volume claims using label selectors. Three API objects manage snapshots: VolumeGroupSnapshot, VolumeGroupSnapshotContent, and VolumeGroupSnapshotClass.

@gcharot gcharot Sep 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add somewhere in this section that this feature is CSI driver dependent, the driver must support volume group snap.
We mention this later in the create section but i would like to also mention it in the introduction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnufied gnufied Awaiting requested review from gnufied
2 more reviewers
@gcharot gcharot gcharot left review comments
@dobsonj dobsonj dobsonj left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-5.0 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 5.0 GA

Development

Successfully merging this pull request may close these issues.

6 participants

@lpettyjo @ocpdocs-previewbot @duanwei33 @gcharot @dobsonj @kalexand-rh