CNTRLPLANE-2769: Bump k8s dependencies to 1.35#2219
Open
ardaguclu wants to merge 9 commits intoopenshift:mainfrom
Open
CNTRLPLANE-2769: Bump k8s dependencies to 1.35#2219ardaguclu wants to merge 9 commits intoopenshift:mainfrom
ardaguclu wants to merge 9 commits intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@ardaguclu: This pull request references CNTRLPLANE-2769 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughBumps Go toolchain to 1.25 and upgrades many module dependencies; updates RHEL builder/base image tags and kubectl metadata; adjusts a manifest.Include call to accept two new params; refactors CLI plugin discovery/logging flow; and adds test exceptions and watch-reactor behavior tweaks. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
bot
added
the
approved
ardaguclu
commented
Mar 6, 2026
| Platform *string | ||
|
|
||
| // EnabledFeatureGates, if non-nil, excludes manifests unless they match the enabled feature gates. | ||
| EnabledFeatureGates sets.Set[string] |
Member
Author
There was a problem hiding this comment.
@wking @hongkailiu I'll need your expertise on the changes here. When I get the latest library-go, build starts failing due to the signature change in Include function. I'd appreciate if these are correct?
|
@ardaguclu: This pull request references CNTRLPLANE-2769 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ardaguclu
commented
Mar 6, 2026
| cmd.Help() | ||
| } | ||
|
|
||
| func moved(fullName, to string, parent, cmd *cobra.Command) string { |
Member
Author
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 211: The go.mod entry for k8s.io/kube-aggregator is at v0.35.1 while all
other k8s.io/* modules are v0.35.2; update the k8s.io/kube-aggregator module to
v0.35.2 (change the version for the k8s.io/kube-aggregator line or run `go get
k8s.io/kube-aggregator@v0.35.2`) and then run `go mod tidy` to refresh go.sum so
the patch-level skew is resolved; ensure the updated k8s.io/kube-aggregator
entry now reads v0.35.2 and rebuild/tests pass.
- Line 185: The project depends on a vulnerable fulcio version
(github.com/sigstore/fulcio v1.6.6); update the go.mod entry to v1.8.5 or later,
then run module tooling to update checksums and lockfiles (e.g., `go get
github.com/sigstore/fulcio@v1.8.5` and `go mod tidy`) so go.sum reflects the
change; after updating, build and run tests (verify
pkg/cli/admin/release/mirror.go compiles and its imports still work) and commit
the updated go.mod and go.sum.
- Line 39: The go.mod currently requires github.com/onsi/ginkgo/v2 at v2.27.2
while the project uses a replace to openshift/onsi-ginkgo which is pinned at
v2.6.x; fix by either (A) updating the openshift/onsi-ginkgo fork to track
upstream v2.27.2 (bump its module/tag and update the replace target to that
newer tag) or (B) remove the replace entirely and change the module requirement
to use the official github.com/onsi/ginkgo/v2 version (adjust require to the
desired v2.x and run go get github.com/onsi/ginkgo/v2@v2.27.2), then run go mod
tidy and go test to verify; look for the replace directive and the require of
github.com/onsi/ginkgo/v2 in go.mod to apply the change.
In `@pkg/cli/admin/release/extract_tools.go`:
- Line 1301: The call to m.Include is currently passing nil for the MajorVersion
parameter, which prevents major-version filtering from ever activating; change
the final argument from nil to config.MajorVersion so
m.Include(config.ExcludeIdentifier, config.RequiredFeatureSet, config.Profile,
config.Capabilities, config.Overrides, config.EnabledFeatureGates,
config.MajorVersion) forwards the configured MajorVersion into Include and
enables the intended filtering behavior.
In `@pkg/cli/cli.go`:
- Around line 341-344: The code logs the raw original command string
(originalCommand built from
cmd.Annotations[kuberc.KubeRCOriginalCommandAnnotation]) which may leak
sensitive flags; replace the direct klog.V(1).Info(fmt.Sprintf("original
command: %q", originalCommand)) with a sanitized/log-safe value by either (a)
implementing and calling a helper like redactArgs(originalCommandArgs) that
strips or masks known sensitive flag names/values (e.g., --password, --token,
--secret, -p, --kubeconfig) before formatting, or (b) logging only non-sensitive
metadata such as the root command name and the number of arguments; update the
call site to use the redacted string or metadata instead of originalCommand and
ensure the helper is reused wherever originalCommandArgs is read.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 62359910-1ea7-4140-8530-2149ecbfcfdb
⛔ Files ignored due to path filters (291)
go.sumis excluded by!**/*.sumvendor/github.com/asaskevich/govalidator/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/.travis.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/CODE_OF_CONDUCT.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/CONTRIBUTING.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/arrays.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/converter.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/error.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/numerics.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/patterns.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/utils.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/validator.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/wercker.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/credentials.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/middleware/user_agent.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream/debug.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream/encode.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream/error.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream/header.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream/header_value.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/transport/http/client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/transport/http/timeout_read_closer.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/config/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/config/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/config/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/config/provider.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/config/resolve.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/config/resolve_credentials.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/config/shared_config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/credentials/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/credentials/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/credentials/logincreds/dpop.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/credentials/logincreds/file.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/credentials/logincreds/provider.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/credentials/logincreds/token.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetDynamicData.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetIAMInfo.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetInstanceIdentityDocument.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetMetadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetRegion.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetToken.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetUserData.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/request_middleware.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/s3/manager/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/s3/manager/default_read_seeker_write_to.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/s3/manager/default_writer_read_from.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/s3/manager/download.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/s3/manager/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/s3/manager/pool.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/s3/manager/read_seeker_write_to.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/s3/manager/upload.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/s3/manager/writer_read_from.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/partitions.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/partitions.jsonis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/v2/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/v2/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/v2/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/ini/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/ini/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/v4a/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/v4a/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/v4a/smithy.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/v4a/v4a.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/checksum/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/checksum/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/checksum/middleware_add.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/checksum/middleware_compute_input_checksum.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/checksum/middleware_setup_context.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/presigned-url/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/presigned-url/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/presigned-url/middleware.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/s3shared/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/s3shared/arn_lookup.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/s3shared/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/s3shared/response_error.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_AbortMultipartUpload.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_CompleteMultipartUpload.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_CopyObject.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_CreateBucket.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_CreateBucketMetadataConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_CreateBucketMetadataTableConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_CreateMultipartUpload.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_CreateSession.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucket.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketAnalyticsConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketCors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketEncryption.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketIntelligentTieringConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketInventoryConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketLifecycle.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketMetadataConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketMetadataTableConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketMetricsConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketOwnershipControls.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketPolicy.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketReplication.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketTagging.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketWebsite.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteObject.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteObjectTagging.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteObjects.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeletePublicAccessBlock.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketAbac.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketAccelerateConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketAcl.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketAnalyticsConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketCors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketEncryption.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketIntelligentTieringConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketInventoryConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketLifecycleConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketLocation.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketLogging.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketMetadataConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketMetadataTableConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketMetricsConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketNotificationConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketOwnershipControls.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketPolicy.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketPolicyStatus.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketReplication.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketRequestPayment.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketTagging.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketVersioning.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketWebsite.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetObject.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetObjectAcl.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetObjectAttributes.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetObjectLegalHold.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetObjectLockConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetObjectRetention.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetObjectTagging.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetObjectTorrent.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetPublicAccessBlock.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_HeadBucket.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_HeadObject.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListBucketAnalyticsConfigurations.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListBucketIntelligentTieringConfigurations.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListBucketInventoryConfigurations.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListBucketMetricsConfigurations.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListBuckets.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListDirectoryBuckets.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListMultipartUploads.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListObjectVersions.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListObjects.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListObjectsV2.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListParts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketAbac.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketAccelerateConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketAcl.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketAnalyticsConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketCors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketEncryption.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketIntelligentTieringConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketInventoryConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketLifecycleConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketLogging.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketMetricsConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketNotificationConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketOwnershipControls.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketPolicy.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketReplication.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketRequestPayment.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketTagging.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketVersioning.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketWebsite.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutObject.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutObjectAcl.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutObjectLegalHold.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutObjectLockConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutObjectRetention.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutObjectTagging.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutPublicAccessBlock.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_RenameObject.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_RestoreObject.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_SelectObjectContent.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_UpdateBucketMetadataInventoryTableConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_UpdateBucketMetadataJournalTableConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_UpdateObjectEncryption.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_UploadPart.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_UploadPartCopy.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_WriteGetObjectResponse.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/auth.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/bucket_context.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/bucketer.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/deserializers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/express_default.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/generated.jsonis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/internal/endpoints/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/presign_post.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/serializers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/types/enums.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/types/errors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/types/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/validators.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/LICENSE.txtis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/api_client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/api_op_CreateOAuth2Token.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/auth.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/deserializers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/generated.jsonis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/internal/endpoints/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/serializers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/types/enums.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/types/errors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/types/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/validators.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/api_client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/api_op_GetRoleCredentials.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/api_op_ListAccountRoles.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/api_op_ListAccounts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/api_op_Logout.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/auth.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/generated.jsonis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/internal/endpoints/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/api_client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/api_op_CreateToken.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/api_op_CreateTokenWithIAM.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/api_op_RegisterClient.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/api_op_StartDeviceAuthorization.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/auth.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/generated.jsonis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/internal/endpoints/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_AssumeRole.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_AssumeRoleWithSAML.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_AssumeRoleWithWebIdentity.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_AssumeRoot.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_DecodeAuthorizationMessage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_GetAccessKeyInfo.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_GetCallerIdentity.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_GetDelegatedAccessToken.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_GetFederationToken.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_GetSessionToken.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_GetWebIdentityToken.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/auth.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/deserializers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/generated.jsonis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/internal/endpoints/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/serializers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/types/errors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/validators.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/smithy-go/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/smithy-go/Makefileis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/smithy-go/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/smithy-go/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/smithy-go/metrics/nop.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/smithy-go/middleware/eventstream_middleware.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/smithy-go/middleware/ordered_group.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/smithy-go/middleware/step_build.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/smithy-go/middleware/step_deserialize.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/smithy-go/middleware/step_finalize.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/smithy-go/middleware/step_initialize.gois excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (9)
.ci-operator.yamlMakefilego.modimages/cli-artifacts/Dockerfile.rhelimages/cli/Dockerfile.rhelimages/recycler/Dockerfile.rhelimages/tools/Dockerfilepkg/cli/admin/release/extract_tools.gopkg/cli/cli.go
| github.com/sigstore/rekor v1.3.6 // indirect | ||
| github.com/sigstore/sigstore v1.8.4 // indirect | ||
| github.com/secure-systems-lab/go-securesystemslib v0.9.0 // indirect | ||
| github.com/sigstore/fulcio v1.6.6 // indirect |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify where fulcio/sigstore are pulled into this repo and whether they are used.
# Read-only reconnaissance only.
set -euo pipefail
echo "== fulcio/sigstore references in go.mod/go.sum =="
rg -n 'sigstore/fulcio|sigstore/sigstore|sigstore/protobuf-specs' go.mod go.sum || true
echo
echo "== Code imports/usages that may make vulns reachable =="
rg -n --type=go 'sigstore|fulcio' -g '!**/vendor/**' || trueRepository: openshift/oc
Length of output: 1162
🌐 Web query:
GO-2025-4193 and GO-2026-4311 github.com/sigstore/fulcio vulnerability patched version
💡 Result:
- GO-2025-4193 (CVE-2025-66506 / GHSA-f83f-xpx7-ffpw) affects
github.com/sigstore/fulcio< v1.8.3 → patched in v1.8.3. [1][2] - GO-2026-4311 (CVE-2026-22772 / GHSA-59jp-pj84-45mr) affects
github.com/sigstore/fulcio< v1.8.5 → patched in v1.8.5. [3][4]
If you want one version that covers both: upgrade to Fulcio v1.8.5+. [3][4]
Sources
[1] https://pkg.go.dev/vuln/GO-2025-4193
[2] GHSA-f83f-xpx7-ffpw
[3] https://pkg.go.dev/vuln/GO-2026-4311
[4] GHSA-59jp-pj84-45mr
Upgrade github.com/sigstore/fulcio from v1.6.6 to v1.8.5+.
Version v1.6.6 is vulnerable to GO-2025-4193 (patched in v1.8.3) and GO-2026-4311 (patched in v1.8.5). The dependency is actively used in pkg/cli/admin/release/mirror.go, making these vulnerabilities reachable. Upgrade to v1.8.5 or later before merge.
🧰 Tools
🪛 OSV Scanner (2.3.3)
[HIGH] 185-185: github.com/sigstore/fulcio 1.6.6: Fulcio allocates excessive memory during token parsing in github.com/sigstore/fulcio
(GO-2025-4193)
[HIGH] 185-185: github.com/sigstore/fulcio 1.6.6: Fulcio is vulnerable to Server-Side Request Forgery (SSRF) via MetaIssuer Regex Bypass in github.com/sigstore/fulcio
(GO-2026-4311)
[HIGH] 185-185: github.com/sigstore/fulcio 1.6.6: Fulcio is vulnerable to Server-Side Request Forgery (SSRF) via MetaIssuer Regex Bypass
[HIGH] 185-185: github.com/sigstore/fulcio 1.6.6: Fulcio allocates excessive memory during token parsing
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 185, The project depends on a vulnerable fulcio version
(github.com/sigstore/fulcio v1.6.6); update the go.mod entry to v1.8.5 or later,
then run module tooling to update checksums and lockfiles (e.g., `go get
github.com/sigstore/fulcio@v1.8.5` and `go mod tidy`) so go.sum reflects the
change; after updating, build and run tests (verify
pkg/cli/admin/release/mirror.go compiles and its imports still work) and commit
the updated go.mod and go.sum.
| k8s.io/metrics v0.34.1 // indirect | ||
| sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8 // indirect | ||
| k8s.io/component-helpers v0.35.2 // indirect | ||
| k8s.io/kube-aggregator v0.35.1 // indirect |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Show all k8s.io module versions from go.mod for skew review.
set -euo pipefail
rg -n '^\s*k8s\.io/' go.modRepository: openshift/oc
Length of output: 635
Resolve Kubernetes patch version skew: k8s.io/kube-aggregator is v0.35.1 while all other core k8s.io/* modules are v0.35.2.
All Kubernetes core modules (api, apiserver, client-go, kubectl, component-helpers, metrics, etc.) are pinned to v0.35.2, while kube-aggregator lags at v0.35.1. This patch-level mismatch can cause subtle compatibility issues. Either update kube-aggregator to v0.35.2 or document why the deliberate skew is necessary.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 211, The go.mod entry for k8s.io/kube-aggregator is at
v0.35.1 while all other k8s.io/* modules are v0.35.2; update the
k8s.io/kube-aggregator module to v0.35.2 (change the version for the
k8s.io/kube-aggregator line or run `go get k8s.io/kube-aggregator@v0.35.2`) and
then run `go mod tidy` to refresh go.sum so the patch-level skew is resolved;
ensure the updated k8s.io/kube-aggregator entry now reads v0.35.2 and
rebuild/tests pass.
| func newIncluder(config manifestInclusionConfiguration) includer { | ||
| return func(m *manifest.Manifest) error { | ||
| return m.Include(config.ExcludeIdentifier, config.RequiredFeatureSet, config.Profile, config.Capabilities, config.Overrides) | ||
| return m.Include(config.ExcludeIdentifier, config.RequiredFeatureSet, config.Profile, config.Capabilities, config.Overrides, config.EnabledFeatureGates, nil) |
There was a problem hiding this comment.
Forward MajorVersion instead of hardcoding nil.
Line 1301 ignores config.MajorVersion, so major-version filtering can never activate even if configured.
🛠️ Proposed fix
- return m.Include(config.ExcludeIdentifier, config.RequiredFeatureSet, config.Profile, config.Capabilities, config.Overrides, config.EnabledFeatureGates, nil)
+ return m.Include(config.ExcludeIdentifier, config.RequiredFeatureSet, config.Profile, config.Capabilities, config.Overrides, config.EnabledFeatureGates, config.MajorVersion)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@pkg/cli/admin/release/extract_tools.go` at line 1301, The call to m.Include
is currently passing nil for the MajorVersion parameter, which prevents
major-version filtering from ever activating; change the final argument from nil
to config.MajorVersion so m.Include(config.ExcludeIdentifier,
config.RequiredFeatureSet, config.Profile, config.Capabilities,
config.Overrides, config.EnabledFeatureGates, config.MajorVersion) forwards the
configured MajorVersion into Include and enables the intended filtering
behavior.
Comment on lines
+341
to
+344
| if originalCommandArgs, ok := cmd.Annotations[kuberc.KubeRCOriginalCommandAnnotation]; ok { | ||
| originalCommand := fmt.Sprintf("%s %s", cmd.Root().Name(), originalCommandArgs) | ||
| klog.V(1).Info(fmt.Sprintf("original command: %q", originalCommand)) | ||
| } |
There was a problem hiding this comment.
Do not log raw original command arguments.
Line 343 logs the full original command string, which can leak sensitive CLI inputs (e.g., credential-bearing flags) when verbosity is enabled.
🔐 Proposed fix
- if originalCommandArgs, ok := cmd.Annotations[kuberc.KubeRCOriginalCommandAnnotation]; ok {
- originalCommand := fmt.Sprintf("%s %s", cmd.Root().Name(), originalCommandArgs)
- klog.V(1).Info(fmt.Sprintf("original command: %q", originalCommand))
- }
+ if _, ok := cmd.Annotations[kuberc.KubeRCOriginalCommandAnnotation]; ok {
+ klog.V(1).Infof("kuberc original command annotation detected for %q", cmd.CommandPath())
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| if originalCommandArgs, ok := cmd.Annotations[kuberc.KubeRCOriginalCommandAnnotation]; ok { | |
| originalCommand := fmt.Sprintf("%s %s", cmd.Root().Name(), originalCommandArgs) | |
| klog.V(1).Info(fmt.Sprintf("original command: %q", originalCommand)) | |
| } | |
| if _, ok := cmd.Annotations[kuberc.KubeRCOriginalCommandAnnotation]; ok { | |
| klog.V(1).Infof("kuberc original command annotation detected for %q", cmd.CommandPath()) | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@pkg/cli/cli.go` around lines 341 - 344, The code logs the raw original
command string (originalCommand built from
cmd.Annotations[kuberc.KubeRCOriginalCommandAnnotation]) which may leak
sensitive flags; replace the direct klog.V(1).Info(fmt.Sprintf("original
command: %q", originalCommand)) with a sanitized/log-safe value by either (a)
implementing and calling a helper like redactArgs(originalCommandArgs) that
strips or masks known sensitive flag names/values (e.g., --password, --token,
--secret, -p, --kubeconfig) before formatting, or (b) logging only non-sensitive
metadata such as the root command name and the number of arguments; update the
call site to use the redacted string or metadata instead of originalCommand and
ensure the helper is reused wherever originalCommandArgs is read.
This was referenced Mar 6, 2026
Closed
|
@ardaguclu: This pull request references CNTRLPLANE-2769 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pkg/helpers/describe/describer_test.go (1)
138-142: Make the new GVK exception list test-private and self-documented.On Line 139, the symbol is exported but only used in tests here. Consider making it unexported and adding short per-entry reasons to match the style used by other exception lists.
♻️ Suggested cleanup
-// MissingDescriberGVKExceptions lists specific GroupVersionKind that don't need describers -var MissingDescriberGVKExceptions = []schema.GroupVersionKind{ - {Group: "etcd.openshift.io", Version: "v1alpha1", Kind: "PacemakerCluster"}, - {Group: "apiextensions.openshift.io", Version: "v1alpha1", Kind: "CompatibilityRequirement"}, +// missingDescriberGVKExceptions lists specific GroupVersionKind that don't need describers. +var missingDescriberGVKExceptions = []schema.GroupVersionKind{ + {Group: "etcd.openshift.io", Version: "v1alpha1", Kind: "PacemakerCluster"}, // CRD-backed; no dedicated describer + {Group: "apiextensions.openshift.io", Version: "v1alpha1", Kind: "CompatibilityRequirement"}, // CRD-backed; no dedicated describer }- for _, exception := range MissingDescriberGVKExceptions { + for _, exception := range missingDescriberGVKExceptions {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pkg/helpers/describe/describer_test.go` around lines 138 - 142, Change the exported MissingDescriberGVKExceptions to a test-private symbol (rename to missingDescriberGVKExceptions) and make it self-documenting by replacing the plain schema.GroupVersionKind slice with a small slice of structs that include both the GVK and a short "reason" string for each entry; update any test references to use the new name and struct fields so each entry documents why it’s exempt (e.g., {GVK: ..., Reason: "reason"}), preserving the same entries and behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pkg/helpers/describe/describer_test.go`:
- Around line 138-142: Change the exported MissingDescriberGVKExceptions to a
test-private symbol (rename to missingDescriberGVKExceptions) and make it
self-documenting by replacing the plain schema.GroupVersionKind slice with a
small slice of structs that include both the GVK and a short "reason" string for
each entry; update any test references to use the new name and struct fields so
each entry documents why it’s exempt (e.g., {GVK: ..., Reason: "reason"}),
preserving the same entries and behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1502a4f4-05c5-4dfb-90e3-dbd616933a3a
📒 Files selected for processing (1)
pkg/helpers/describe/describer_test.go
atiratree
reviewed
Mar 6, 2026
| cmd.Help() | ||
| } | ||
|
|
||
| func moved(fullName, to string, parent, cmd *cobra.Command) string { |
| @@ -41,10 +41,10 @@ require ( | |||
| github.com/opencontainers/go-digest v1.0.0 | |||
| github.com/opencontainers/image-spec v1.1.1 | |||
| github.com/openshift-eng/openshift-tests-extension v0.0.0-20250804142706-7b3ab438a292 | |||
Member
Author
There was a problem hiding this comment.
Same comment as #2219 (comment), this is managed by our QE
Member
Author
|
flake? |
Member
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, atiratree The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tchap
reviewed
Mar 6, 2026
| // Command exists(e.g. kubectl create), but it is not certain that | ||
| // subcommand also exists (e.g. kubectl create networkpolicy) | ||
| // we also have to eliminate kubectl create -f | ||
| if kubecmd.IsSubcommandPluginAllowed(foundCmd.Name()) && len(foundArgs) >= 1 && !strings.HasPrefix(foundArgs[0], "-") { |
Contributor
There was a problem hiding this comment.
Since you removed the check, this will now panic on err != nil and `cmdName == "help", for example.
Member
Author
There was a problem hiding this comment.
These changes are carried directly from kubectl https://github.com/kubernetes/kubectl/blob/093dc6671ef294e5dd7ab63db4f9e99f0b45c5ce/pkg/cmd/cmd.go#L107-L162. If you see a difference here with kubectl, I have to fix it in this PR. If you see a bug in kubectl, we will have to fix it in kubectl first.
Contributor
There was a problem hiding this comment.
Ok, there is a latent issue, which is currently harmless. I don't like it, but so be it.
tchap
reviewed
Mar 6, 2026
| originalCommand := fmt.Sprintf("%s %s", cmd.Root().Name(), originalCommandArgs) | ||
| klog.V(1).Info(fmt.Sprintf("original command: %q", originalCommand)) | ||
| } | ||
| return existingPreRunE(cmd, args) |
Contributor
There was a problem hiding this comment.
Shouldn't you check for existingPreRunE != nil? This will panic if the original Pre is unset.
Contributor
There was a problem hiding this comment.
Ok, this field is actually always set, so it's not very defensive, but it's not a bug. Never mind.
Member
Author
|
/test e2e-agnostic-ovn-cmd |
Contributor
|
LGTM for what I was able to review. |
Member
Author
|
/retitle WIP: CNTRLPLANE-2769: Bump k8s dependencies to 1.35 |
Member
Author
|
/testwith openshift/oc/main/e2e-aws-ovn openshift/origin#30850,openshift/openshift-apiserver#618 |
Member
Author
|
/testwith openshift/oc/main/e2e-aws-ovn openshift/openshift-apiserver#619 |
Member
Author
|
/testwith openshift/oc/main/e2e-agnostic-ovn-cmd openshift/openshift-apiserver#619 |
Member
Author
|
/testwith openshift/oc/main/e2e-agnostic-ovn-cmd openshift/cluster-openshift-apiserver-operator#667 |
1 similar comment
Member
Author
|
/testwith openshift/oc/main/e2e-agnostic-ovn-cmd openshift/cluster-openshift-apiserver-operator#667 |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
images/cli/Dockerfile.rhel (1)
4-9:⚠️ Potential issue | 🟠 MajorKeep
/usr/bin/oc-tests-extavailable when adding the gzipped artifact.
gzip oc-tests-extdeletes the original file, and the final stage only ships/usr/bin/oc-tests-ext.gz. This breaks the documented interface in the README, which shows direct execution ofoc-tests-ext(e.g.,./oc-tests-ext run-suite openshift/oc/all).Minimal fix
-RUN make build --warn-undefined-variables \ - && gzip oc-tests-ext +RUN make build --warn-undefined-variables \ + && gzip -c -n oc-tests-ext > oc-tests-ext.gz @@ COPY --from=builder /go/src/github.com/openshift/oc/oc /usr/bin/ +COPY --from=builder /go/src/github.com/openshift/oc/oc-tests-ext /usr/bin/oc-tests-ext COPY --from=builder /go/src/github.com/openshift/oc/oc-tests-ext.gz /usr/bin/oc-tests-ext.gz🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@images/cli/Dockerfile.rhel` around lines 4 - 9, The build stage currently runs "gzip oc-tests-ext" which removes the original binary so the final image only contains /usr/bin/oc-tests-ext.gz; change the builder step to produce a gzipped artifact without deleting the original (e.g., use gzip -c to write oc-tests-ext.gz or copy oc-tests-ext to oc-tests-ext.gz before gzipping) and ensure the final stage copies both /go/src/github.com/openshift/oc/oc-tests-ext and /go/src/github.com/openshift/oc/oc-tests-ext.gz into /usr/bin/ so the uncompressed oc-tests-ext binary remains available for direct execution as documented.
♻️ Duplicate comments (3)
go.mod (2)
211-211:⚠️ Potential issue | 🟠 MajorMajor: Kubernetes patch version skew remains unresolved.
This issue was previously flagged.
k8s.io/kube-aggregatoris at v0.35.1 while all other core Kubernetes modules (api, apiserver, client-go, kubectl, component-helpers, metrics, etc.) are at v0.35.2. Patch-level misalignment can cause subtle compatibility issues in the API server aggregation layer. Either update to v0.35.2 or document the reason for the deliberate skew.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` at line 211, The go.mod entry for k8s.io/kube-aggregator is at v0.35.1 and mismatches the rest of the Kubernetes modules (which are v0.35.2); update the k8s.io/kube-aggregator version to v0.35.2 in go.mod to match api/apiserver/client-go/etc., run `go get k8s.io/kube-aggregator@v0.35.2` and then `go mod tidy` to ensure dependency alignment, or if the skew is intentional, add a clear comment in go.mod or the repo docs explaining why k8s.io/kube-aggregator remains at v0.35.1.
185-185:⚠️ Potential issue | 🔴 CriticalCritical: Unresolved security vulnerabilities in
github.com/sigstore/fulcio v1.6.6.This issue was previously flagged but remains unaddressed. Version v1.6.6 contains two HIGH-severity vulnerabilities:
- GO-2025-4193: Excessive memory allocation during token parsing (patched in v1.8.3)
- GO-2026-4311: SSRF via MetaIssuer regex bypass (patched in v1.8.5)
The dependency is actively used in
pkg/cli/admin/release/mirror.go, making these vulnerabilities reachable. Upgrade to v1.8.5+ is required before merge.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` at line 185, Update the vulnerable fulcio dependency to a patched release: change the module version for github.com/sigstore/fulcio to v1.8.5 or newer in go.mod, then run the module tooling (e.g., go get github.com/sigstore/fulcio@v1.8.5 and go mod tidy) to update go.sum; afterwards rebuild and run tests to ensure pkg/cli/admin/release/mirror.go and any other consumers still compile and behave correctly, and re-run your dependency vulnerability scan to confirm GO-2025-4193 and GO-2026-4311 are resolved.pkg/cli/cli.go (1)
341-344:⚠️ Potential issue | 🟠 MajorDo not log raw kuberc command arguments.
originalCommandArgscan include sensitive flag values (--token,--password, kubeconfig paths, etc.), and this emits them verbatim whenever verbose logging is enabled. Log only sanitized metadata or a redacted form instead.🔐 Safer logging change
- if originalCommandArgs, ok := cmd.Annotations[kuberc.KubeRCOriginalCommandAnnotation]; ok { - originalCommand := fmt.Sprintf("%s %s", cmd.Root().Name(), originalCommandArgs) - klog.V(1).Info(fmt.Sprintf("original command: %q", originalCommand)) - } + if _, ok := cmd.Annotations[kuberc.KubeRCOriginalCommandAnnotation]; ok { + klog.V(1).Infof("kuberc original command annotation detected for %q", cmd.CommandPath()) + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pkg/cli/cli.go` around lines 341 - 344, Current logging prints raw kuberc command args which may contain secrets; change the behavior in the block that reads cmd.Annotations[kuberc.KubeRCOriginalCommandAnnotation] so you do not log verbatim originalCommandArgs or originalCommand. Instead, sanitize or redact sensitive values (e.g., remove flag values for known sensitive flags like --token, --password, --kubeconfig, or replace every flag value with "<redacted>"), or log only safe metadata (such as the root command name and argument count) and then call klog.V(1).Info with the sanitized/redacted string; locate this behavior around cmd.Annotations, originalCommandArgs, originalCommand and klog.V(1).Info and replace the direct fmt.Sprintf logging with the sanitized version.
🧹 Nitpick comments (1)
pkg/cli/deployer/strategy/support/lifecycle_test.go (1)
102-109: Assert that the initialSendInitialEventswatch was actually attempted.These reactors make the fallback path available, but they do not prove it ran. If
executeExecNewPodever skips the initial watch request and goes straight to the plain watch, both tests still pass. Please record that aSendInitialEvents=truewatch was seen and fail the test if it was not.🔎 Example tightening for each test
import ( "bytes" "errors" "io" "reflect" "sort" "strings" + "sync/atomic" "testing" "time" @@ podsWatch := watch.NewFake() + var sawInitialEvents atomic.Bool // The fake client doesn't properly support bookmark events, so we reject SendInitialEvents to force fallback client.PrependWatchReactor("pods", func(action clientgotesting.Action) (handled bool, ret watch.Interface, err error) { watchAction := action.(clientgotesting.WatchActionImpl) if watchAction.ListOptions.SendInitialEvents != nil && *watchAction.ListOptions.SendInitialEvents { + sawInitialEvents.Store(true) return true, nil, errors.New("sendInitialEvents is not supported in fake client") } return clientgotesting.DefaultWatchReactor(podsWatch, nil)(action) }) @@ err := executor.executeExecNewPod(hook, deployment, "hook", "test") + if !sawInitialEvents.Load() { + t.Fatalf("expected initial watch with SendInitialEvents before fallback") + }Also applies to: 175-182
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pkg/cli/deployer/strategy/support/lifecycle_test.go` around lines 102 - 109, The test's watch reactor must assert that an initial watch with ListOptions.SendInitialEvents==true was actually attempted; modify the client.PrependWatchReactor used in lifecycle_test.go to set a shared boolean (e.g., seenInitialSendEvents) to true when the action cast to clientgotesting.WatchActionImpl has ListOptions.SendInitialEvents != nil && *... == true, still returning the same error for the fake client, and after executeExecNewPod completes add an assertion that seenInitialSendEvents is true (fail the test if not). Apply the same change to the second reactor used later in the file so both tests validate the initial SendInitialEvents watch attempt.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@images/cli/Dockerfile.rhel`:
- Around line 4-9: The build stage currently runs "gzip oc-tests-ext" which
removes the original binary so the final image only contains
/usr/bin/oc-tests-ext.gz; change the builder step to produce a gzipped artifact
without deleting the original (e.g., use gzip -c to write oc-tests-ext.gz or
copy oc-tests-ext to oc-tests-ext.gz before gzipping) and ensure the final stage
copies both /go/src/github.com/openshift/oc/oc-tests-ext and
/go/src/github.com/openshift/oc/oc-tests-ext.gz into /usr/bin/ so the
uncompressed oc-tests-ext binary remains available for direct execution as
documented.
---
Duplicate comments:
In `@go.mod`:
- Line 211: The go.mod entry for k8s.io/kube-aggregator is at v0.35.1 and
mismatches the rest of the Kubernetes modules (which are v0.35.2); update the
k8s.io/kube-aggregator version to v0.35.2 in go.mod to match
api/apiserver/client-go/etc., run `go get k8s.io/kube-aggregator@v0.35.2` and
then `go mod tidy` to ensure dependency alignment, or if the skew is
intentional, add a clear comment in go.mod or the repo docs explaining why
k8s.io/kube-aggregator remains at v0.35.1.
- Line 185: Update the vulnerable fulcio dependency to a patched release: change
the module version for github.com/sigstore/fulcio to v1.8.5 or newer in go.mod,
then run the module tooling (e.g., go get github.com/sigstore/fulcio@v1.8.5 and
go mod tidy) to update go.sum; afterwards rebuild and run tests to ensure
pkg/cli/admin/release/mirror.go and any other consumers still compile and behave
correctly, and re-run your dependency vulnerability scan to confirm GO-2025-4193
and GO-2026-4311 are resolved.
In `@pkg/cli/cli.go`:
- Around line 341-344: Current logging prints raw kuberc command args which may
contain secrets; change the behavior in the block that reads
cmd.Annotations[kuberc.KubeRCOriginalCommandAnnotation] so you do not log
verbatim originalCommandArgs or originalCommand. Instead, sanitize or redact
sensitive values (e.g., remove flag values for known sensitive flags like
--token, --password, --kubeconfig, or replace every flag value with
"<redacted>"), or log only safe metadata (such as the root command name and
argument count) and then call klog.V(1).Info with the sanitized/redacted string;
locate this behavior around cmd.Annotations, originalCommandArgs,
originalCommand and klog.V(1).Info and replace the direct fmt.Sprintf logging
with the sanitized version.
---
Nitpick comments:
In `@pkg/cli/deployer/strategy/support/lifecycle_test.go`:
- Around line 102-109: The test's watch reactor must assert that an initial
watch with ListOptions.SendInitialEvents==true was actually attempted; modify
the client.PrependWatchReactor used in lifecycle_test.go to set a shared boolean
(e.g., seenInitialSendEvents) to true when the action cast to
clientgotesting.WatchActionImpl has ListOptions.SendInitialEvents != nil && *...
== true, still returning the same error for the fake client, and after
executeExecNewPod completes add an assertion that seenInitialSendEvents is true
(fail the test if not). Apply the same change to the second reactor used later
in the file so both tests validate the initial SendInitialEvents watch attempt.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 208d6271-3406-468a-ad32-4938f504ebb2
⛔ Files ignored due to path filters (287)
go.sumis excluded by!**/*.sumvendor/github.com/asaskevich/govalidator/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/.travis.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/CODE_OF_CONDUCT.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/CONTRIBUTING.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/arrays.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/converter.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/error.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/numerics.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/patterns.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/utils.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/validator.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/asaskevich/govalidator/wercker.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/credentials.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/middleware/user_agent.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream/debug.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream/encode.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream/error.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream/header.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream/header_value.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/transport/http/client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/aws/transport/http/timeout_read_closer.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/config/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/config/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/config/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/config/provider.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/config/resolve.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/config/resolve_credentials.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/config/shared_config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/credentials/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/credentials/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/credentials/logincreds/dpop.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/credentials/logincreds/file.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/credentials/logincreds/provider.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/credentials/logincreds/token.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetDynamicData.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetIAMInfo.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetInstanceIdentityDocument.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetMetadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetRegion.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetToken.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetUserData.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/request_middleware.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/s3/manager/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/s3/manager/default_read_seeker_write_to.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/s3/manager/default_writer_read_from.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/s3/manager/download.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/s3/manager/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/s3/manager/pool.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/s3/manager/read_seeker_write_to.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/s3/manager/upload.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/feature/s3/manager/writer_read_from.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/partitions.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/partitions.jsonis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/v2/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/v2/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/v2/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/ini/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/ini/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/v4a/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/v4a/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/v4a/smithy.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/internal/v4a/v4a.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/checksum/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/checksum/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/checksum/middleware_add.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/checksum/middleware_compute_input_checksum.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/checksum/middleware_setup_context.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/presigned-url/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/presigned-url/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/presigned-url/middleware.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/s3shared/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/s3shared/arn_lookup.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/s3shared/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/internal/s3shared/response_error.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_AbortMultipartUpload.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_CompleteMultipartUpload.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_CopyObject.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_CreateBucket.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_CreateBucketMetadataConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_CreateBucketMetadataTableConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_CreateMultipartUpload.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_CreateSession.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucket.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketAnalyticsConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketCors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketEncryption.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketIntelligentTieringConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketInventoryConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketLifecycle.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketMetadataConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketMetadataTableConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketMetricsConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketOwnershipControls.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketPolicy.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketReplication.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketTagging.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteBucketWebsite.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteObject.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteObjectTagging.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeleteObjects.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_DeletePublicAccessBlock.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketAbac.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketAccelerateConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketAcl.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketAnalyticsConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketCors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketEncryption.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketIntelligentTieringConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketInventoryConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketLifecycleConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketLocation.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketLogging.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketMetadataConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketMetadataTableConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketMetricsConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketNotificationConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketOwnershipControls.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketPolicy.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketPolicyStatus.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketReplication.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketRequestPayment.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketTagging.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketVersioning.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetBucketWebsite.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetObject.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetObjectAcl.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetObjectAttributes.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetObjectLegalHold.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetObjectLockConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetObjectRetention.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetObjectTagging.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetObjectTorrent.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_GetPublicAccessBlock.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_HeadBucket.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_HeadObject.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListBucketAnalyticsConfigurations.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListBucketIntelligentTieringConfigurations.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListBucketInventoryConfigurations.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListBucketMetricsConfigurations.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListBuckets.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListDirectoryBuckets.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListMultipartUploads.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListObjectVersions.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListObjects.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListObjectsV2.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_ListParts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketAbac.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketAccelerateConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketAcl.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketAnalyticsConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketCors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketEncryption.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketIntelligentTieringConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketInventoryConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketLifecycleConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketLogging.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketMetricsConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketNotificationConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketOwnershipControls.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketPolicy.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketReplication.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketRequestPayment.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketTagging.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketVersioning.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutBucketWebsite.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutObject.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutObjectAcl.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutObjectLegalHold.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutObjectLockConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutObjectRetention.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutObjectTagging.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_PutPublicAccessBlock.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_RenameObject.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_RestoreObject.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_SelectObjectContent.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_UpdateBucketMetadataInventoryTableConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_UpdateBucketMetadataJournalTableConfiguration.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_UpdateObjectEncryption.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_UploadPart.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_UploadPartCopy.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/api_op_WriteGetObjectResponse.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/auth.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/bucket_context.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/bucketer.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/deserializers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/express_default.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/generated.jsonis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/internal/endpoints/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/presign_post.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/serializers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/types/enums.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/types/errors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/types/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/s3/validators.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/LICENSE.txtis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/api_client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/api_op_CreateOAuth2Token.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/auth.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/deserializers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/generated.jsonis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/internal/endpoints/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/serializers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/types/enums.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/types/errors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/types/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/signin/validators.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/api_client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/api_op_GetRoleCredentials.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/api_op_ListAccountRoles.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/api_op_ListAccounts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/api_op_Logout.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/auth.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/generated.jsonis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/internal/endpoints/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sso/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/api_client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/api_op_CreateToken.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/api_op_CreateTokenWithIAM.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/api_op_RegisterClient.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/api_op_StartDeviceAuthorization.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/auth.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/generated.jsonis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/internal/endpoints/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/ssooidc/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_AssumeRole.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_AssumeRoleWithSAML.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_AssumeRoleWithWebIdentity.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_AssumeRoot.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_DecodeAuthorizationMessage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_GetAccessKeyInfo.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_GetCallerIdentity.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_GetDelegatedAccessToken.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_GetFederationToken.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_GetSessionToken.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/api_op_GetWebIdentityToken.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/auth.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/deserializers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/generated.jsonis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/internal/endpoints/endpoints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/serializers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/types/errors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/sts/validators.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/smithy-go/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/smithy-go/Makefileis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/smithy-go/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/smithy-go/go_module_metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/smithy-go/metrics/nop.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/smithy-go/middleware/eventstream_middleware.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/aws/smithy-go/middleware/ordered_group.gois excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (11)
.ci-operator.yamlMakefilego.modimages/cli-artifacts/Dockerfile.rhelimages/cli/Dockerfile.rhelimages/recycler/Dockerfile.rhelimages/tools/Dockerfilepkg/cli/admin/release/extract_tools.gopkg/cli/cli.gopkg/cli/deployer/strategy/support/lifecycle_test.gopkg/helpers/describe/describer_test.go
🚧 Files skipped from review as they are similar to previous changes (4)
- images/cli-artifacts/Dockerfile.rhel
- pkg/helpers/describe/describer_test.go
- .ci-operator.yaml
- pkg/cli/admin/release/extract_tools.go
Member
Author
|
/testwith openshift/oc/main/e2e-agnostic-ovn-cmd openshift/cluster-openshift-apiserver-operator#667 |
Member
Author
|
/testwith openshift/oc/main/e2e-agnostic-ovn-cmd openshift/cluster-openshift-apiserver-operator#667 |
Member
Author
|
/testwith openshift/oc/main/e2e-agnostic-ovn-cmd openshift/cluster-openshift-apiserver-operator#667 |
Member
Author
|
/testwith openshift/oc/main/e2e-agnostic-ovn-cmd openshift/cluster-openshift-apiserver-operator#667 |
Contributor
|
@ardaguclu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Member
Author
|
/testwith openshift/oc/main/e2e-aws-ovn openshift/cluster-openshift-apiserver-operator#667 |
Member
Author
|
/testwith openshift/oc/main/e2e-agnostic-ovn-cmd openshift/cluster-openshift-apiserver-operator#667 |
1 similar comment
Member
Author
|
/testwith openshift/oc/main/e2e-agnostic-ovn-cmd openshift/cluster-openshift-apiserver-operator#667 |
Member
Author
|
/testwith openshift/oc/main/e2e-aws-ovn openshift/cluster-openshift-apiserver-operator#667 |
Member
Author
|
/testwith openshift/oc/main/e2e-agnostic-ovn-cmd openshift/cluster-openshift-apiserver-operator#667 |
Member
Author
|
/testwith openshift/oc/main/e2e-agnostic-ovn-cmd openshift/cluster-openshift-apiserver-operator#667 |
Member
|
Hey @ardaguclu, do you know any timelines for the merge of this ? It currently blocks our PR here openshift/cloud-provider-azure#155 (comment) due to https://redhat.atlassian.net/browse/OCPBUGS-77845 (which should be fixed by this PR). Thanks |
Member
Author
@damdo this openshift/cluster-openshift-apiserver-operator#667 is pending for review/approval which will unblock this PR. So I believe that this PR will be ready soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the dependencies to align with k8s 1.35.
Summary by CodeRabbit
Updates
New Features
Improvements
Tests