OCPBUGS-66940: fix default image for confidential VMs

[patrickdillon]

The installer still creates an image gallery for confidfential VMs, and we can tell its a confidential VM from the machine provider spec, so this updates the default to point to an installer-created gallery rather than the marketplace image.

[openshift-ci-robot]

@patrickdillon: This pull request references Jira Issue OCPBUGS-66244, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The installer still creates an image gallery for confidfential VMs, and we can tell its a confidential VM from the machine provider spec, so this updates the default to point to an installer-created gallery rather than the marketplace image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

/test unit

[sunzhaohua2]

/verified by @sunzhaohua2
Tested on confidential VM cluster, with this pr, if we don't specify image, machine can be created succeed.

$ oc get machine                                                                                             
NAME                                                   PHASE     TYPE                 REGION       ZONE   AGE
ci-op-x4r75bt8-b6d04-7tsnr-master-0                    Running   Standard_DC4es_v5    westeurope   2      97m
ci-op-x4r75bt8-b6d04-7tsnr-master-1                    Running   Standard_DC4es_v5    westeurope   2      97m
ci-op-x4r75bt8-b6d04-7tsnr-master-2                    Running   Standard_DC4es_v5    westeurope   2      97m
ci-op-x4r75bt8-b6d04-7tsnr-worker-westeurope2-47h44    Running   Standard_DC4ads_v5   westeurope   2      91m
ci-op-x4r75bt8-b6d04-7tsnr-worker-westeurope2-nwhqb    Running   Standard_DC4ads_v5   westeurope   2      91m
ci-op-x4r75bt8-b6d04-7tsnr-worker-westeurope2-qr8gt    Running   Standard_DC4ads_v5   westeurope   2      91m
ci-op-x4r75bt8-b6d04-7tsnr-worker-westeurope21-9jsgx   Running   Standard_DC4ads_v5   westeurope   2      5m39s
$ oc get machine ci-op-x4r75bt8-b6d04-7tsnr-worker-westeurope21-9jsgx -o yaml                               
      image:
        offer: ""
        publisher: ""
        resourceID: /resourceGroups/ci-op-x4r75bt8-b6d04-7tsnr-rg/providers/Microsoft.Compute/galleries/gallery_ci_op_x4r75bt8_b6d04_7tsnr/images/ci-op-x4r75bt8-b6d04-7tsnr-gen2/versions/latest
        sku: ""
        version: ""

[openshift-ci-robot]

@sunzhaohua2: This PR has been marked as verified by @sunzhaohua2.

Details

In response to this:

/verified by @sunzhaohua2
With pr 1443, if we don't specify image, machine can be created succeed.

$ oc get machine                                                                                             
NAME                                                   PHASE     TYPE                 REGION       ZONE   AGE
ci-op-x4r75bt8-b6d04-7tsnr-master-0                    Running   Standard_DC4es_v5    westeurope   2      97m
ci-op-x4r75bt8-b6d04-7tsnr-master-1                    Running   Standard_DC4es_v5    westeurope   2      97m
ci-op-x4r75bt8-b6d04-7tsnr-master-2                    Running   Standard_DC4es_v5    westeurope   2      97m
ci-op-x4r75bt8-b6d04-7tsnr-worker-westeurope2-47h44    Running   Standard_DC4ads_v5   westeurope   2      91m
ci-op-x4r75bt8-b6d04-7tsnr-worker-westeurope2-nwhqb    Running   Standard_DC4ads_v5   westeurope   2      91m
ci-op-x4r75bt8-b6d04-7tsnr-worker-westeurope2-qr8gt    Running   Standard_DC4ads_v5   westeurope   2      91m
ci-op-x4r75bt8-b6d04-7tsnr-worker-westeurope21-9jsgx   Running   Standard_DC4ads_v5   westeurope   2      5m39s
$ oc get machine ci-op-x4r75bt8-b6d04-7tsnr-worker-westeurope21-9jsgx -o yaml                               
     image:
       offer: ""
       publisher: ""
       resourceID: /resourceGroups/ci-op-x4r75bt8-b6d04-7tsnr-rg/providers/Microsoft.Compute/galleries/gallery_ci_op_x4r75bt8_b6d04_7tsnr/images/ci-op-x4r75bt8-b6d04-7tsnr-gen2/versions/latest
       sku: ""
       version: ""

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[nrb]

/title OCPBUGS-66240: fix default image for confidential VMs

[nrb]

/retitle OCPBUGS-66240: fix default image for confidential VMs

[openshift-ci-robot]

@patrickdillon: This pull request references Jira Issue OCPBUGS-66240, which is invalid:

• expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.20.z" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The installer still creates an image gallery for confidfential VMs, and we can tell its a confidential VM from the machine provider spec, so this updates the default to point to an installer-created gallery rather than the marketplace image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sunzhaohua2]

/retitle OCPBUGS-66940: fix default image for confidential VMs

[openshift-ci-robot]

@patrickdillon: This pull request references Jira Issue OCPBUGS-66940, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The installer still creates an image gallery for confidfential VMs, and we can tell its a confidential VM from the machine provider spec, so this updates the default to point to an installer-created gallery rather than the marketplace image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

/cherry-pick release-4.21

[openshift-cherrypick-robot]

@damdo: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tthvo]

/jira refresh

[openshift-ci-robot]

@tthvo: This pull request references Jira Issue OCPBUGS-66940, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

@tthvo @patrickdillon what's the status of this, is it still something we want to merge? TY

[perdasilva]

@tthvo @patrickdillon this has been hanging around for a bit - is it something we want to get merged?

[patrickdillon]

@damdo @perdasilva Yes you can merge it. There are no customer cases and I don't believe confidential VMs are a common use case, so I'm also fine just to close it. But AFAIK it's a valid bug and fix.

[JoelSpeed]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@patrickdillon: Jira Issue Verification Checks: Jira Issue OCPBUGS-66940
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-66940 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

The installer still creates an image gallery for confidfential VMs, and we can tell its a confidential VM from the machine provider spec, so this updates the default to point to an installer-created gallery rather than the marketplace image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@damdo: new pull request created: #1513

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.