OCPBUGS-105407: Remove VSphereMultiNetworks feature gate

[vr4manta]

OCPBUGS-105407

Changes

• Removed usages of VSphereMultiNetworks feature gate

Notes

VSphereMultiNetworks has been GA for several releases. Remove the feature gate checks from the installer so that multi-network topology and nodeNetworking fields are accepted unconditionally.

Also, some of the feature gate checks were removed in past PRs.

Summary by CodeRabbit

• Changes

  • vSphere network configuration validation no longer depends on the multi-network feature gate.
  • Failure-domain and node-network validation entries have been removed from gated checks.
  • Machine-network CIDR fallback and explicit node-network precedence remain unchanged.

• Tests

  • Updated vSphere configuration test descriptions to reflect the current network behavior.
  • Existing test scenarios and expected results remain unchanged.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@vr4manta: This pull request references Jira Issue OCPBUGS-105407, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

OCPBUGS-105407

Changes

• Removed usages of VSphereMultiNetworks feature gate

Notes

VSphereMultiNetworks has been GA for several releases. Remove the feature gate checks from the installer so that multi-network topology and nodeNetworking fields are accepted unconditionally.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4837ed39-deda-4c26-b873-fb813f11aaab

📥 Commits

Reviewing files that changed from the base of the PR and between 4745066 and 138941f.

📒 Files selected for processing (2)

• pkg/asset/manifests/vsphere/cloudproviderconfig_test.go
• pkg/types/vsphere/validation/featuregates.go

💤 Files with no reviewable changes (1)

• pkg/types/vsphere/validation/featuregates.go

🚧 Files skipped from review as they are similar to previous changes (1)

• pkg/asset/manifests/vsphere/cloudproviderconfig_test.go

---

📝 Walkthrough

Walkthrough

Changes

vSphere network validation

Layer / File(s)	Summary
Remove multi-network validation and update configuration descriptions pkg/types/vsphere/validation/featuregates.go, pkg/asset/manifests/vsphere/cloudproviderconfig_test.go	vSphere validation no longer detects multiple networks or adds VSphereMultiNetworks entries. Test comments now describe machine-network CIDR fallback and explicit install-config precedence. Test inputs and expected outputs are unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: lgtm

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely identifies the main change: removing the VSphereMultiNetworks feature gate.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only test comments and feature-gate validation. All t.Run titles remain fixed descriptive literals; no dynamic values or overly specific changed titles are present.
Test Structure And Quality	✅ Passed	The diff changes only comments in a testify table-driven unit test; it has no Ginkgo or cluster operations, waits, or resources, and its assertions have diagnostic messages.
Microshift Test Compatibility	✅ Passed	The patch adds no Ginkgo e2e tests; it only changes comments in the standard-library TestCloudProviderConfig test, so the MicroShift test check does not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The diff adds no Ginkgo e2e tests. It only edits comments in a Go unit test and removes vSphere feature-gate validation entries, so SNO test compatibility is not implicated.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit only removes vSphere feature-gate validation and updates test comments; it adds no manifests, controllers, replicas, affinity, topology spread, selectors, tolerations, or PDB constraints.
Ote Binary Stdout Contract	✅ Passed	The pull request changes only vSphere validation entries and test comments; it adds no process-level stdout writes in an OTE binary.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff adds no Ginkgo e2e tests; it only changes comments and removes feature-gate validation entries. Existing IPv4 test data is unchanged.
No-Weak-Crypto	✅ Passed	The diff only removes vSphere feature-gate validation and updates test comments; it adds no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret-comparison code.
Container-Privileges	✅ Passed	The diff changes Go comments and removes vSphere feature-gate validation entries; it adds no container/Kubernetes privilege settings or root execution configuration.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only removes feature-gate validation and edits test comments. Diff scans found no new logging or output calls and no sensitive data in added lines.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

_{Comment @coderabbitai help to get the list of available commands.}

[rvanderp3]

/lgtm
/assign vr4manta

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-vsphere-multi-vcenter-ovn
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-devpreview
/test e2e-vsphere-ovn-disk-setup-techpreview
/test e2e-vsphere-ovn-hybrid-env
/test e2e-vsphere-ovn-techpreview
/test e2e-vsphere-ovn-zones
/test e2e-aws-ovn

[jcpowermac]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/asset/manifests/vsphere/OWNERS [jcpowermac]
• pkg/types/vsphere/validation/OWNERS [jcpowermac]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vr4manta]

/verified by @vr4manta

[openshift-ci-robot]

@vr4manta: This PR has been marked as verified by @vr4manta.

Details

In response to this:

/verified by @vr4manta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[vr4manta]

/verified by @vr4manta

[openshift-ci-robot]

@vr4manta: This PR has been marked as verified by @vr4manta.

Details

In response to this:

/verified by @vr4manta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@vr4manta: This pull request references Jira Issue OCPBUGS-105407, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

OCPBUGS-105407

Changes

• Removed usages of VSphereMultiNetworks feature gate

Notes

VSphereMultiNetworks has been GA for several releases. Remove the feature gate checks from the installer so that multi-network topology and nodeNetworking fields are accepted unconditionally.

Also, some of the feature gate checks were removed in past PRs.

Summary by CodeRabbit

• Changes

• vSphere network configuration validation no longer depends on the multi-network feature gate.

• Failure-domain and node-network validation entries have been removed from gated checks.

• Machine-network CIDR fallback and explicit node-network precedence remain unchanged.

• Tests

• Updated vSphere configuration test descriptions to reflect the current network behavior.

• Existing test scenarios and expected results remain unchanged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jcpowermac]

/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-vsphere-multi-vcenter-ovn
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-devpreview
/test e2e-vsphere-ovn-disk-setup-techpreview
/test e2e-vsphere-ovn-hybrid-env
/test e2e-vsphere-ovn-techpreview
/test e2e-vsphere-ovn-zones
/test e2e-aws-ovn

[openshift-ci-robot]

@vr4manta: Jira Issue OCPBUGS-105407: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

• openshift/api#2975 is open

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-105407 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

OCPBUGS-105407

Changes

• Removed usages of VSphereMultiNetworks feature gate

Notes

VSphereMultiNetworks has been GA for several releases. Remove the feature gate checks from the installer so that multi-network topology and nodeNetworking fields are accepted unconditionally.

Also, some of the feature gate checks were removed in past PRs.

Summary by CodeRabbit

• Changes

• vSphere network configuration validation no longer depends on the multi-network feature gate.

• Failure-domain and node-network validation entries have been removed from gated checks.

• Machine-network CIDR fallback and explicit node-network precedence remain unchanged.

• Tests

• Updated vSphere configuration test descriptions to reflect the current network behavior.

• Existing test scenarios and expected results remain unchanged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn-devpreview	138941f	link	false	/test e2e-vsphere-ovn-devpreview
ci/prow/e2e-vsphere-multi-vcenter-ovn	138941f	link	false	/test e2e-vsphere-multi-vcenter-ovn
ci/prow/e2e-vsphere-ovn-zones	138941f	link	false	/test e2e-vsphere-ovn-zones

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.