Skip to content

[release-4.22] OCPBUGS-113630: Fix for CVE-2026-39830 - #9373

Closed
rhdmalone wants to merge 6 commits into
openshift:release-4.22from
rhdmalone:release-4.22-CVE-2026-39830
Closed

[release-4.22] OCPBUGS-113630: Fix for CVE-2026-39830#9373
rhdmalone wants to merge 6 commits into
openshift:release-4.22from
rhdmalone:release-4.22-CVE-2026-39830

Conversation

@rhdmalone

Copy link
Copy Markdown

What this PR does / why we need it:

updates the version of x/crypto to fix CVE-2026-39830

Which issue(s) this PR fixes:

Fixes CVE-2026-39830

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 21, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@rhdmalone: This pull request explicitly references no jira issue.

Details

In response to this:

What this PR does / why we need it:

updates the version of x/crypto to fix CVE-2026-39830

Which issue(s) this PR fixes:

Fixes CVE-2026-39830

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Team

Run ID: 45771364-ae6d-41ca-abe7-47397e64c5a4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from bryan-cox and sjenning August 21, 2026 16:03
@openshift-ci openshift-ci Bot added area/ci-tooling Indicates the PR includes changes for CI or tooling and removed do-not-merge/needs-area labels Aug 21, 2026
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.81818% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.55%. Comparing base (2f5225b) to head (a843207).

Files with missing lines Patch % Lines
hypershift-operator/main.go 61.81% 20 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-4.22    #9373      +/-   ##
================================================
+ Coverage         36.53%   36.55%   +0.01%     
================================================
  Files               777      777              
  Lines             95363    95410      +47     
================================================
+ Hits              34840    34874      +34     
- Misses            57682    57694      +12     
- Partials           2841     2842       +1     
Files with missing lines Coverage Δ
hypershift-operator/main.go 4.43% <61.81%> (+4.43%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bryan-cox

Copy link
Copy Markdown
Member

This should not be a no jira issue. Is there no Jira for the CVE?

@rhdmalone rhdmalone changed the title [release-4.22] NO-JIRA: Fix for CVE-2026-39830 [release-4.22] OCPBUGS-113284: Fix for CVE-2026-39830 Aug 24, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 24, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@rhdmalone: This pull request references Jira Issue OCPBUGS-113284, which is invalid:

  • expected the vulnerability to target either version "4.22.0." or "openshift-4.22.0.", but it targets "4.21.z" instead
  • expected Jira Issue OCPBUGS-113284 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:

updates the version of x/crypto to fix CVE-2026-39830

Which issue(s) this PR fixes:

Fixes CVE-2026-39830

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhdmalone

Copy link
Copy Markdown
Author

/test Gitlint

@rhdmalone
rhdmalone force-pushed the release-4.22-CVE-2026-39830 branch 3 times, most recently from 47d871c to d625d91 Compare August 24, 2026 12:14
@germanparente

Copy link
Copy Markdown

/label jira/skip-dependent-bug-check

@openshift-ci openshift-ci Bot added the jira/skip-dependent-bug-check Indicates that the referenced Jira bug does not require a dependent bug. label Aug 24, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 24, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@rhdmalone: This pull request references Jira Issue OCPBUGS-113284, which is valid. The bug has been moved to the POST state.

4 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

Details

In response to this:

What this PR does / why we need it:

updates the version of x/crypto to fix CVE-2026-39830

Which issue(s) this PR fixes:

Fixes CVE-2026-39830

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhdmalone
rhdmalone force-pushed the release-4.22-CVE-2026-39830 branch from d625d91 to e13c592 Compare August 24, 2026 12:25
@rhdmalone
rhdmalone force-pushed the release-4.22-CVE-2026-39830 branch from e13c592 to 7728599 Compare August 24, 2026 12:35
@openshift-ci openshift-ci Bot added the area/api Indicates the PR includes changes for the API label Aug 24, 2026
@rhdmalone

Copy link
Copy Markdown
Author

/test verify-deps

@everettraven everettraven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendor-only API changes.

/approve for api

@rhdmalone rhdmalone changed the title [release-4.22] OCPBUGS-113284: Fix for CVE-2026-39830 [release-4.22] OCPBUGS-113630: Fix for CVE-2026-39830 Aug 26, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@rhdmalone: This pull request references Jira Issue OCPBUGS-113630, which is valid. The bug has been moved to the POST state.

4 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:

updates the version of x/crypto to fix CVE-2026-39830

Which issue(s) this PR fixes:

Fixes CVE-2026-39830

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox bryan-cox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, everettraven, rhdmalone

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2026
@dhgautam99

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-azure-aks-external-oidc
/test e2e-azure-self-managed
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws

@bryan-cox

Copy link
Copy Markdown
Member

/retest

@rhdmalone

Copy link
Copy Markdown
Author

/retest-required

@rhdmalone

Copy link
Copy Markdown
Author

/test e2e-aws-upgrade-hypershift-operator

    Bump golang.org/x/crypto to address CVE-2026-39830 plus fix for failing test

Signed-off-by: Deirdre Malone <dmalone@redhat.com>
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2026
@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci Bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label Aug 27, 2026
rhdmalone and others added 2 commits August 27, 2026 16:52
    Bump golang.org/x/crypto to address CVE-2026-39830 plus fix for failing test

Signed-off-by: Deirdre Malone <dmalone@redhat.com>
Bump golang.org/x/crypto to address CVE-2026-39830 plus fix for failing test.

Signed-off-by: Deirdre Malone <dmalone@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@rhdmalone
rhdmalone force-pushed the release-4.22-CVE-2026-39830 branch from 947d31a to 41370b5 Compare August 27, 2026 16:23
Bump golang.org/x/crypto to address CVE-2026-39830 plus fix for failing test.

Signed-off-by: Deirdre Malone <dmalone@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@rhdmalone

Copy link
Copy Markdown
Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2026
@rhdmalone

Copy link
Copy Markdown
Author

/test e2e-aws-upgrade-hypershift-operator

Bump golang.org/x/crypto to address CVE-2026-39830 plus fix for failing test.

Signed-off-by: Deirdre Malone <dmalone@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@rhdmalone

Copy link
Copy Markdown
Author

/test e2e-aws-upgrade-hypershift-operator

@rhdmalone

Copy link
Copy Markdown
Author

/test e2e-aws-upgrade-hypershift-operator
Rerunning the test in case this is an infrastructure flake

@openshift-ci

openshift-ci Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@rhdmalone: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-upgrade-hypershift-operator a843207 link true /test e2e-aws-upgrade-hypershift-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhdmalone

Copy link
Copy Markdown
Author

e2e-aws-upgrade-hypershift-operator is failing
#9487 contains no code changes

@rhdmalone rhdmalone closed this Sep 2, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@rhdmalone: This pull request references Jira Issue OCPBUGS-113630. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:

updates the version of x/crypto to fix CVE-2026-39830

Which issue(s) this PR fixes:

Fixes CVE-2026-39830

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates the PR includes changes for the API area/ci-tooling Indicates the PR includes changes for CI or tooling area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/skip-dependent-bug-check Indicates that the referenced Jira bug does not require a dependent bug. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants