Skip to content

NO-JIRA: add ceo disruptive suite to sippy's disruptive - #1667

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
dusk125:ceo-disruptive
Aug 1, 2026
Merged

NO-JIRA: add ceo disruptive suite to sippy's disruptive#1667
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
dusk125:ceo-disruptive

Conversation

@dusk125

@dusk125 dusk125 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Add the CEO's disruptive suite to the disruptive-longrunning so sippy will pick it up and give us signal for openshift/api#2946

Summary by CodeRabbit

  • Tests
    • Updated the disruptive Cluster Etcd Operator test suite classification to run under the disruptive long-running test suite.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 31, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@dusk125: This pull request explicitly references no jira issue.

Details

In response to this:

Add the CEO's disruptive suite to the disruptive-longrunning so sippy will pick it up and give us signal for openshift/api#2946

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7174d8f9-1e09-442f-bcd7-4e39d0ac5d4f

📥 Commits

Reviewing files that changed from the base of the PR and between ccd95c6 and ba44c69.

📒 Files selected for processing (1)
  • cmd/cluster-etcd-operator-tests-ext/main.go

Walkthrough

The disruptive Cluster Etcd Operator test suite now uses openshift/disruptive-longrunning as its parent suite.

Changes

Test suite classification

Layer / File(s) Summary
Assign the disruptive parent suite
cmd/cluster-etcd-operator-tests-ext/main.go
The disruptive test suite configuration sets openshift/disruptive-longrunning as its parent suite.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Test Structure And Quality ⚠️ Warning The targeted suite contains missing cleanup and weak diagnostics: backup.go creates resources without cleanup, scaling_dbsize.go leaves the Etcd CR changed, and many assertions omit messages. Add cleanup that restores cluster state and deletes created resources, use bounded contexts for cluster commands, and add meaningful messages to assertions.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding the Cluster Etcd Operator disruptive suite to Sippy's disruptive suite.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only the suite Parents field. No Ginkgo title is added or modified, and the selected disruptive test titles are static string literals.
Microshift Test Compatibility ✅ Passed The PR only adds a parent suite declaration; it adds no Ginkgo tests or MicroShift-incompatible API references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only suite metadata by adding a parent suite; it adds no new Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The only change adds a parent suite label to the test registry; it modifies no deployment, operator, controller, or scheduling constraint.
Ote Binary Stdout Contract ✅ Passed The PR adds only a struct field initialization (Parents field) with no stdout writes, function calls, or I/O operations; no OTE Binary Stdout Contract violations detected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit adds only the suite parent declaration; it adds no Ginkgo tests or new network and external-connectivity behavior.
No-Weak-Crypto ✅ Passed The PR adds only the suite Parents metadata; the diff and changed Go file contain no weak-crypto APIs, custom crypto, or secret/token comparisons.
Container-Privileges ✅ Passed The patch adds only a Go suite parent declaration; it adds no container/Kubernetes manifest or privilege setting.
No-Sensitive-Data-In-Logs ✅ Passed The only change adds a suite parent string. The diff adds no logging calls, credentials, tokens, PII, hostnames, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Comment @coderabbitai help to get the list of available commands.

@sandeepknd

Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-agnostic-ovn
/test e2e-agnostic-ovn-upgrade
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-aws-ovn-single-node
/test e2e-gcp-operator
/test e2e-gcp-operator-disruptive
/test e2e-metal-ipi-ovn-ipv6
/test e2e-operator

@dusk125

dusk125 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-disruptive-longrunning-techpreview

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@dusk125: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-disruptive-longrunning-techpreview-1of2
  • periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-disruptive-longrunning-techpreview-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c767f810-8cf2-11f1-9bb1-101eff6abd21-0

@dusk125

dusk125 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

/approve
Will verify when the launched payloads complete, assuming they successfully run our test

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2026
@dusk125

dusk125 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

/verified by payload run

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 31, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@dusk125: This PR has been marked as verified by payload run.

Details

In response to this:

/verified by payload run

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD ccd95c6 and 2 for PR HEAD ba44c69 in total

@openshift-ci

openshift-ci Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

@dusk125: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 10741fc into openshift:main Aug 1, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants