Skip to content

OKD-320:Migrate to OKD featureset for OKD clusters#462

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Prashanth684:okd-migrate-cco
Feb 2, 2026
Merged

OKD-320:Migrate to OKD featureset for OKD clusters#462
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Prashanth684:okd-migrate-cco

Conversation

@Prashanth684
Copy link
Contributor

@Prashanth684 Prashanth684 commented Jan 28, 2026

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from benluddy and tkashem January 28, 2026 18:16
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

@Prashanth684: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Prashanth684 Prashanth684 changed the title WIP: Migrate to OKD featureset for OKD clusters Migrate to OKD featureset for OKD clusters Jan 29, 2026
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2026
@Prashanth684 Prashanth684 mentioned this pull request Jan 29, 2026
Closed
@Prashanth684 Prashanth684 changed the title Migrate to OKD featureset for OKD clusters OKD-320:Migrate to OKD featureset for OKD clusters Jan 29, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 29, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 29, 2026 •
edited by openshift-ci bot
Loading

@Prashanth684: This pull request references OKD-320 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

In lieu of openshift/cluster-version-operator#1287 similar to #324

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

JoelSpeed
JoelSpeed reviewed Jan 30, 2026
View reviewed changes
pkg/operator/migrateokdfeatureset/migrateokdfeatureset_controller.go
// Only migrate if the current featureset is Default (empty string or explicit "Default")
// The installer creates FeatureGate with OKD featureset for new installations.
// This controller migrates existing clusters upgraded to OKD.
if featureGates.Spec.FeatureSet != "" && featureGates.Spec.FeatureSet != configv1.Default {
Copy link
Contributor

@JoelSpeed JoelSpeed Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is already OKD, you can also exit early here

Copy link
Contributor Author

@Prashanth684 Prashanth684 Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would already do that. It exits if the featureset is anything other than Default.

Copy link
Contributor

@JoelSpeed JoelSpeed Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

Yep, misread that

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Feb 1, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, Prashanth684

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2026
@Prashanth684
Copy link
Contributor Author

Prashanth684 commented Feb 2, 2026

/verified by @jatinsu

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 2, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 2, 2026

@Prashanth684: This PR has been marked as verified by @jatinsu.

Details

In response to this:

/verified by @jatinsu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit b04cc2d into openshift:main Feb 2, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@benluddy benluddy Awaiting requested review from benluddy

@tkashem tkashem Awaiting requested review from tkashem

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Prashanth684 @openshift-ci-robot @JoelSpeed